[
https://issues.apache.org/jira/browse/WICKET-5573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988166#comment-13988166
]
Leszek Gawron commented on WICKET-5573:
---------------------------------------
Martin, if I created a quickstart app it wouldn't event compile with 6.15.
The rationale for this functionality is give here:
http://markmail.org/message/bmz7x4ingzzvwfo4
The change is dead simple:
{code}
diff --git
c/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
i/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
index ebea180..22d2d1b 100644
---
c/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
+++
i/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
@@ -57,8 +57,8 @@ public class FilterToolbar extends AbstractToolbar
* type of filter state object
*
*/
- public <T, S> FilterToolbar(final DataTable<T, S> table, final
FilterForm<T> form,
- final IFilterStateLocator<T> stateLocator)
+ public <T, F, S> FilterToolbar(final DataTable<T, S> table, final
FilterForm<F> form,
+ final IFilterStateLocator<F> stateLocator)
{
super(table);
{code}
This actually did work in 1.4.19
> FilterToolbar generics broken
> -----------------------------
>
> Key: WICKET-5573
> URL: https://issues.apache.org/jira/browse/WICKET-5573
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.15.0
> Reporter: Leszek Gawron
>
> Once you were able to create DataTable<User> wrapped inside of
> FilterForm<UserFilterDto>
> currently FilterToolbar requires you for those two types to be identical:
> {code}
> public <T, S> FilterToolbar(final DataTable<T, S> table, final
> FilterForm<T> form,
> final IFilterStateLocator<T> stateLocator)
> {code}
> It looks like commit 9b3f9ca1df064fe9c6fde64ccc37fecc504b09a6
> introduced a bug long time ago and it carried on:
> {code}
> - public <T> FilterToolbar(final DataTable<?> table, final
> FilterForm<T> form,
> + public <T> FilterToolbar(final DataTable<T> table, final
> FilterForm<T> form,
> {code}
> FilterToolbar constructor should state:
> {code}
> public <T, F, S> FilterToolbar(final DataTable<T, S> table, final
> FilterForm<F> form,
> final IFilterStateLocator<F> stateLocator)
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
