Repository: wicket Updated Branches: refs/heads/wicket-6.x b5e29819b -> d38050896
Minor improvements: - append char instead of String - do not calculate the idValue in a loop Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d3805089 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d3805089 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d3805089 Branch: refs/heads/wicket-6.x Commit: d38050896b20f98bee1457a0359458e9618307ad Parents: b5e2981 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Tue Jul 22 11:12:51 2014 +0300 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Tue Jul 22 11:12:51 2014 +0300 ---------------------------------------------------------------------- .../org/apache/wicket/markup/html/form/ListMultipleChoice.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/d3805089/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java index be0d4d9..e3cf4f3 100644 --- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java +++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java @@ -227,11 +227,13 @@ public class ListMultipleChoice<T> extends AbstractChoice<Collection<T>, T> // Have a value at all? if (selected != null) { + String idValue = getChoiceRenderer().getIdValue(choice, index); + // Loop through ids for (final StringTokenizer tokenizer = new StringTokenizer(selected, VALUE_SEPARATOR); tokenizer.hasMoreTokens();) { final String id = tokenizer.nextToken(); - if (id.equals(getChoiceRenderer().getIdValue(choice, index))) + if (id.equals(idValue)) { return true; } @@ -339,7 +341,7 @@ public class ListMultipleChoice<T> extends AbstractChoice<Collection<T>, T> for (T t : unchangedModel) { builder.append(t); - builder.append(";"); + builder.append(';'); } selected = builder.toString(); }
