[ 
https://issues.apache.org/jira/browse/WICKET-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096880#comment-14096880
 ] 

Carl-Eric Menzel commented on WICKET-5265:
------------------------------------------

We encountered the same problem, except rather than with RefreshingView, we saw 
it with Wizard components. The underlying issue is the same: In onRemove the 
FencedFeedbackPanel removes the fence mark from its fence component, but if the 
FFP is added back later, the fence mark is not restored.

I'll attach a much simpler patch that simply verifies whether the fence mark is 
still there and recreates it if necessary. All tests run, including one 
checking for the bad behavior.

[~svenmeier], if you have no objections to this patch, I'll commit it for 6.x 
and 7.

> FencedFeedbackPanel is broken with RefreshingView(and it's implementations)
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-5265
>                 URL: https://issues.apache.org/jira/browse/WICKET-5265
>             Project: Wicket
>          Issue Type: Bug
>            Reporter: vineet semwal
>              Labels: DataView, FencedFeedbackPanel, RefreshingView
>         Attachments: WICKET-5265.patch, second.patch
>
>
> FencedFeedbackPanel doesn't work correctly if inner form(s) are in 
> RefreshingView(or it's implementations)..
> in this case outerform feedbackpanel just starts including messages meant for 
> inner feedbackpanel.
> with ListView FencedFeedbackPanel works correctly..
> actually one user(Mike Dundee) created this issue in quickview 
> https://github.com/vineetsemwal/quickview/issues/19
>  so in that link he has described his problem and pasted the code you can use 
> to reproduce ...
> there i have also explained why it's broken with RefreshingView and it's 
> implementations currently(it's a little complex so i am trying to avoid 
> explaining all again ,also english is not my first language :-) ) 
> thank you !



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to