[ 
https://issues.apache.org/jira/browse/WICKET-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126732#comment-14126732
 ] 

Martin Grigorov commented on WICKET-5689:
-----------------------------------------

In my opinion this code snippet should be removed completely.
If BufferedResponseRequestHandler has the chance to handle the request it will 
do its job. But if something else (like the use case in this ticket) tries to 
handle the request in another way then Wicket should not try to "recover" in 
such a late phase of the request processing.

Opinions ?

> Nested Redirects and REDIRECT_TO_BUFFER
> ---------------------------------------
>
>                 Key: WICKET-5689
>                 URL: https://issues.apache.org/jira/browse/WICKET-5689
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.5.11, 6.16.0
>         Environment: Windows 7, tomcat 7.0.47
>            Reporter: Mike
>            Priority: Minor
>         Attachments: nestedredirects.tar.gz
>
>
> When the render strategy is REDIRECT_TO_BUFFER, redirects cannot be nested. 
> After the second redirect, Wicket renders the buffered first page in 
> preference to the second page. The relevant code is in 
> WebPageRenderer.respond:
> {noformat}
>               if (bufferedResponse != null)
>               {
>                       logger.warn("The Buffered response should be handled by 
> BufferedResponseRequestHandler");
>                       // if there is saved response for this URL render it
>                       
> bufferedResponse.writeTo((WebResponse)requestCycle.getResponse());
>               }
> {noformat}
> The attached quickstart demonstrates the issue. Simply navigate to the home 
> page. The observed behavior is that Page1 is displayed, but I expect Page2 to 
> be displayed.
> I can work around the issue by calling 
> WebApplication.getAndRemoveBufferedResponse() to clear the render buffer, but 
> I am uneasy with this solution since it seems like I am playing with Wicket 
> internals; albeit the function is public. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to