[jira] [Commented] (WICKET-5717) Url.parse/toString should support fragment

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163265#comment-14163265
 ] 

ASF GitHub Bot commented on WICKET-5717:
----------------------------------------

Github user martin-g commented on the pull request:

    https://github.com/apache/wicket/pull/78#issuecomment-58332442
  
    After merging this PR to wicket-6.x the following tests fail:
    ```
    Failed tests:   
optionPlaceholderDecode1(org.apache.wicket.core.request.mapper.MountedMapperTest)
      
optionPlaceholderDecodeEagerMatchParameters(org.apache.wicket.core.request.mapper.MountedMapperTest)
      
optionPlaceholderDecode2(org.apache.wicket.core.request.mapper.MountedMapperTest)
      
optionPlaceholderDecode3(org.apache.wicket.core.request.mapper.MountedMapperTest)
      
optionPlaceholderDecodeWithIndexParams(org.apache.wicket.core.request.mapper.MountedMapperTest)
      
optionPlaceholderEncode1(org.apache.wicket.core.request.mapper.MountedMapperTest):
 expected:<some/[p1/path/p2/i1/i2?a=b&b=c]> but 
was:<some/[/i1/i2?a=b&b=c&param1=p1&param2=p2]>
      
optionPlaceholderEncode2(org.apache.wicket.core.request.mapper.MountedMapperTest):
 expected:<some/[path/p2/p3/i1/i2?a=b&b=c]> but 
was:<some/[/i1/i2?a=b&b=c&param2=p2&param3=p3]>
    ```
    
    I'll investigate.


> Url.parse/toString should support fragment
> ------------------------------------------
>
>                 Key: WICKET-5717
>                 URL: https://issues.apache.org/jira/browse/WICKET-5717
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.17.0
>            Reporter: Guillaume Smet
>            Assignee: Martin Grigorov
>         Attachments: redirect-url-anchor.tar.gz
>
>
> Hi,
> Starting with Wicket 6.16, we have issues redirecting to an absolute
> URL containing a fragment: the # is escaped by Wicket.
> Changes in the commit
> https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8
> are causing the regression but as far as we can see, the commit is not
> the problem: the issue is that Url.parse then toString encodes the
> anchor.
> Before this commit, as we were using an absolute Url, we were in the
> case where the Url wasn't escaped.
> We think the right fix would be to make org.apache.wicket.request.Url
> anchor aware.
> Pull request to come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)