[ 
https://issues.apache.org/jira/browse/WICKET-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186462#comment-14186462
 ] 

ASF GitHub Bot commented on WICKET-5735:
----------------------------------------

GitHub user bravehorsie opened a pull request:

    https://github.com/apache/wicket/pull/79

    WICKET-5735 maxFileSize per file in upload request

    added Form.setFileMaxSize(Bytes fileMaxSize)
    added MultipartServletWebRequestImpl.newFileUpload(Bytes maxSize, Bytes 
fileMaxSize, FileItemFactory factory, String encoding)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bravehorsie/wicket WICKET-5735_maxFileSize

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #79
    
----
commit a0f9d5a0b0ed16f5c1adc52f2f85b6b9cdaa383b
Author: Roman Grigoriadi <bravehor...@gmail.com>
Date:   2014-10-28T06:19:15Z

    WICKET-5735 maxFileSize per file in upload request

----


> Propagate fileSizeMax attribute to 
> org.apache.commons.fileupload.FileUploadBase
> -------------------------------------------------------------------------------
>
>                 Key: WICKET-5735
>                 URL: https://issues.apache.org/jira/browse/WICKET-5735
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Roman Grigoriadi
>            Priority: Minor
>
> Wicket's MultipartServletWebRequestImpl uses commons ServletFileUpload 
> internally, but there is no way to configure this component, for example to 
> propagate fileSizeMax inside.
> As supposed in 
> http://apache-wicket.1842946.n4.nabble.com/org-apache-wicket-util-upload-FileUploadBase-fileSizeMax-td4668001.html
>  there should be implemented:
> 1) add Form#fileSizeMax and pass it to MultipartServletWebRequest 
> 2) add MultipartServletWebRequestImpl#newFileUpload(FileItemFactory) 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to