[ 
https://issues.apache.org/jira/browse/WICKET-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273055#comment-14273055
 ] 

ASF subversion and git services commented on WICKET-5806:
---------------------------------------------------------

Commit 4d2e5680b23e55984e8ac159bdce63629e57df12 in wicket's branch 
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=4d2e568 ]

WICKET-5806 JSHint: 'console' is a global object

Fixes the build a our CI

(cherry picked from commit f14b5b108a493c2f25b1cdcef25f57908766d4f3)


> Wicket.Log should log (at least errors) in the browser console even when 
> Wicket Ajax Debug window is disabled
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-5806
>                 URL: https://issues.apache.org/jira/browse/WICKET-5806
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 6.18.0
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 7.0.0-M5, 6.19.0
>
>
> When 
> org.apache.wicket.settings.IDebugSettings#setAjaxDebugModeEnabled(false)wicket-ajax.js
>  won't log any errors to the browser console because of the check at:
> https://github.com/apache/wicket/blob/8a3bd97825647301833751e906f441577e3fb3a5/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js#L231
> I think errors should be logged to the browser console if there is a 
> window.console object no matter what is the value of the setting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to