[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305241#comment-14305241 ]
ASF GitHub Bot commented on WICKET-5827: ---------------------------------------- Github user bitstorm commented on a diff in the pull request: https://github.com/apache/wicket/pull/87#discussion_r24089981 --- Diff: wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java --- @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.wicket.resource; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.wicket.css.ICssCompressor; + +/** + * Used to apply several {@link ICssCompressor} to the css compression.<br> + * <br> + * Usage: + * + * <pre> + * CompositeCssCompressor compositeCssCompressor = new CompositeCssCompressor(); + * + * compositeCssCompressor.getCompressors().add(new MyCssCompressor()); + * compositeCssCompressor.getCompressors().add(new AnotherCssCompressor()); + * + * this.getResourceSettings().setCssCompressor(compositeCssCompressor); + * </pre> + * @since 6.20.0 + * @author Tobias Soloschenko + * + */ +public class CompositeCssCompressor implements ICssCompressor +{ + + /* Compressors to compress the CSS content */ + private List<ICssCompressor> compressors; + --- End diff -- Personally I would initialize compressors in-line so we can skip 'if (compressors != null)' checks. In addition I would also add a constructor with multiple args for compressors : 'CompositeCssCompressor(ICssCompressor...)' . Same for CompositeJavaScriptCompressor. > Allow to apply multiple Javascript / CSS compressors > ---------------------------------------------------- > > Key: WICKET-5827 > URL: https://issues.apache.org/jira/browse/WICKET-5827 > Project: Wicket > Issue Type: New Feature > Components: wicket > Affects Versions: 6.20.0, 7.0.0-M6 > Reporter: Tobias Soloschenko > Priority: Minor > Labels: features > > It would be nice to be able to add several css and javascript compressions in > a chain. Example for CSS: > CssRemoveCommentsCompressor > CssUrlReplacementCompressor > > CssMinifyCompressor > The same would be nice for JavaScript files. > https://github.com/apache/wicket/pull/88 > https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)