[ 
https://issues.apache.org/jira/browse/WICKET-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348856#comment-14348856
 ] 

ASF GitHub Bot commented on WICKET-5848:
----------------------------------------

GitHub user klopfdreh opened a pull request:

    https://github.com/apache/wicket/pull/104

    Wicket 5848

    For more information see: 
    Ticket: https://issues.apache.org/jira/browse/WICKET-5848
    Discussion: 
http://apache-wicket.1842946.n4.nabble.com/DISCUSSION-Remove-settings-of-projects-in-github-td4669818.html
    
    !!!!! Upload wicket-eclipse-settings in version 1 to central maven 
repository first !!!!!
    
    <dependency>
        <groupId>org.apache.wicket</groupId>
        <artifactId>wicket-eclipse-settings</artifactId>
        <version>1</version>
    </dependency>
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/klopfdreh/wicket WICKET-5848

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
    
----
commit 1f3ca3ffe2ba7633339719824fb5e12197bcb243
Author: klopfdreh <[email protected]>
Date:   2015-03-04T22:21:07Z

    WICKET-5848 - Remove .settings folders of projects

commit c910bd707edb31b669b7e408b52e7b822aff37ff
Author: klopfdreh <[email protected]>
Date:   2015-03-05T08:10:19Z

    WICKET-5848 - Revert test-file / fixed formatting

commit f027f20c6df1bfe848406893884c70223f225176
Author: klopfdreh <[email protected]>
Date:   2015-03-05T08:33:25Z

    WICKET-5848 - Added org.eclipse.jdt.core.prefs

commit f002348a1dd152fa4728746539db122895e319a8
Author: klopfdreh <[email protected]>
Date:   2015-03-05T09:03:58Z

    WICKET-5848 - Removed parent from wicket-eclipse-settings / added files

commit 6e30ac20147d8b0ce5a0d7382ae2727ad4c8fccc
Author: klopfdreh <[email protected]>
Date:   2015-03-05T09:40:52Z

    WICKET-5848 - Finalized

----


> Remove .settings folders of projects
> ------------------------------------
>
>                 Key: WICKET-5848
>                 URL: https://issues.apache.org/jira/browse/WICKET-5848
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket
>    Affects Versions: 7.0.0-M6
>            Reporter: Tobias Soloschenko
>            Priority: Minor
>              Labels: maven
>
> Discussed here:
> http://apache-wicket.1842946.n4.nabble.com/DISCUSSION-Remove-settings-of-projects-in-github-td4669818.html
> 1. Delete every .settings folders out of the maven projects and make sure 
> that maven is going to setup the projects right if "configure as maven 
> project" is invoked.
> 2. Ensure that the code style formatter is applied to the eclipse settings if 
> the project is configured as maven project. 
> Emond suggested: https://github.com/topicusonderwijs/m2e-settings



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to