Repository: wicket Updated Branches: refs/heads/master 4f7c7b351 -> 1d740488b
Reverted change for WICKET-5875 and added docs for method renderComponent Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1d740488 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1d740488 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1d740488 Branch: refs/heads/master Commit: 1d740488b30491c92ca03eaf579fcf9ce0989796 Parents: 4f7c7b3 Author: Andrea Del Bene <[email protected]> Authored: Sat Apr 11 19:58:00 2015 +0200 Committer: Andrea Del Bene <[email protected]> Committed: Sat Apr 11 19:58:00 2015 +0200 ---------------------------------------------------------------------- .../wicket/core/util/string/ComponentRenderer.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/1d740488/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java b/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java index 0f134dc..52b3a82 100644 --- a/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java +++ b/wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java @@ -69,6 +69,10 @@ public class ComponentRenderer /** * Collects the html generated by the rendering of a component. + * + * NOTE: this method i meant to render fresh component instances that are disposed after the + * html has been generate. To avoid unwanted side effects do not use it with components that + * are from an existing hierarchy. * * @param component * the component to render. @@ -87,12 +91,9 @@ public class ComponentRenderer { requestCycle.setResponse(tempResponse); - if (component.getParent() == null) - { - // add the component to a dummy page just for the rendering - RenderPage page = new RenderPage(component); - page.internalInitialize(); - } + // add the component to a dummy page just for the rendering + RenderPage page = new RenderPage(component); + page.internalInitialize(); component.render(); }
