[
https://issues.apache.org/jira/browse/WICKET-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545496#comment-14545496
]
ASF GitHub Bot commented on WICKET-5906:
----------------------------------------
GitHub user gsmet opened a pull request:
https://github.com/apache/wicket/pull/118
WICKET-5906 Move StringResourceModel to a fluid API
I was wondering if maybe setModel and setParameters should be more clear,
such as setSubstitutionModel and setSubstitutionParameters.
Comments welcome.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/openwide-java/wicket stringresourcemodel-fluid
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #118
----
commit ebfe6e804c80abdc6748d6d45d3ae6e4128e86de
Author: Guillaume Smet <[email protected]>
Date: 2015-05-15T13:29:52Z
WICKET-5906 Move StringResourceModel to a fluid API
This commit breaks the API late in the release cycle of 7 but
changes made to the constructors of StringResourceModel made
some usages silently failing.
We decided in favor of breaking the API to raise compilation
errors so that users can fix their code.
----
> Use default on missing resource does not work
> ---------------------------------------------
>
> Key: WICKET-5906
> URL: https://issues.apache.org/jira/browse/WICKET-5906
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 7.0.0-M5
> Reporter: Martijn Dashorst
> Fix For: 7.0.0-M6
>
>
> A regression since 6.19.0: when a StringResourceModel tries to lookup a key,
> but that key doesn't exist in any of the resource bundles, it should use the
> default if one is provided (and the setting is enabled in Wicket's
> ResourceSettings), but currently throws an exception, or returns a string
> with a warning that the resource could not be found.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
