[
https://issues.apache.org/jira/browse/WICKET-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641791#comment-14641791
]
ASF subversion and git services commented on WICKET-1718:
---------------------------------------------------------
Commit 319a6b86082596d88095f15279486117ad361e03 in wicket's branch
refs/heads/wicket-6.x from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=319a6b8 ]
WICKET-1718 check successful rendering of page before validating headers
Conflicts:
wicket-core/src/test/java/org/apache/wicket/RestartResponseAtInterceptPageExceptionTest.java
> WebPage#onAfterRender erroneously reports missing header
> --------------------------------------------------------
>
> Key: WICKET-1718
> URL: https://issues.apache.org/jira/browse/WICKET-1718
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4
> Reporter: Sven Meier
> Assignee: Juergen Donnerstag
> Fix For: 1.4-RC2
>
>
> In WebPage#onAfterRender() there's a check wether a header was missing on a
> page and header contributions would be lost.
> In the following case this check erroneously barks:
> - page A was requested
> - in A's onBeforeRender() a RestartResponseAtInterceptPageException to page B
> is thrown
> - page A's onAfterRender() is invoked in a finally block
> - processing continues with page B
> Page A's onAfterRender() complains about the missing header, althought his
> page was never completely rendered.
> IMHO there's a check missing in WebPage#onAfterRender():
> if (getRequestCycle().getResponsePage() == this) {
> .....
> }
> Or is Page A not allowed to throw RestartResponseAtInterceptPageException in
> onBeforeRender() at all?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
