[ 
https://issues.apache.org/jira/browse/WICKET-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699213#comment-14699213
 ] 

Martijn Dashorst commented on WICKET-5961:
------------------------------------------

I still think this is a regression from 6 to 7. The mentioned commit 
f89b15618243075f8a8e90cb826550af525dabb7 removes previous working markup, and 
I'm not convinced the two tests failing (MarkupFragmentTest.panel and 
MarkupFragmentTest.panelWithAutoComponent) are actually testing a valid 
assumption (because I don't know what the assumption is that they are 
testing--I only see the state being tested).

> Wicket1.5 TreeTable can't find markup
> -------------------------------------
>
>                 Key: WICKET-5961
>                 URL: https://issues.apache.org/jira/browse/WICKET-5961
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 7.0.0
>            Reporter: Martijn Dashorst
>
> The recently moved TreeTable can't find its markup (for a TreeTableItem):
> {code}
> org.apache.wicket.markup.MarkupNotFoundException: Markup not found for 
> Component: [TreeTableItem [Component id = 0]]
>       at org.apache.wicket.Component.internalRender(Component.java:2347)
>       at org.apache.wicket.Component.render(Component.java:2307)
>       at 
> org.apache.wicket.extensions.markup.html.tree.table.SideColumnsView.onRender(SideColumnsView.java:103)
>       at org.apache.wicket.Component.internalRender(Component.java:2379)
>       at org.apache.wicket.Component.render(Component.java:2307)
>       at 
> org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1407)
>       at 
> org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1604)
>       at 
> org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1579)
>       at 
> org.apache.wicket.MarkupContainer.renderAssociatedMarkup(MarkupContainer.java:691)
>       at 
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderAssociatedMarkup(AssociatedMarkupSourcingStrategy.java:77)
>       at 
> org.apache.wicket.markup.html.panel.PanelMarkupSourcingStrategy.onComponentTagBody(PanelMarkupSourcingStrategy.java:112)
>       at 
> org.apache.wicket.Component.internalRenderComponent(Component.java:2564)
>       at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1543)
>       at org.apache.wicket.Component.internalRender(Component.java:2379)
>       at org.apache.wicket.Component.render(Component.java:2307)
>       at 
> org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1407)
>       at 
> org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1604)
>       at org.apache.wicket.Page.onRender(Page.java:879)
>       at org.apache.wicket.markup.html.WebPage.onRender(WebPage.java:141)
>       at org.apache.wicket.Component.internalRender(Component.java:2379)
>       at org.apache.wicket.Component.render(Component.java:2307)
>       at org.apache.wicket.Page.renderPage(Page.java:1018)
>       at 
> org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:124)
>       at 
> org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:236)
>       at 
> org.apache.wicket.util.tester.BaseWicketTester$LastPageRecordingPageRendererProvider$1.respond(BaseWicketTester.java:2745)
>       at 
> org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:175)
>       at 
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:865)
>       at 
> org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64)
>       at 
> org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:265)
>       at 
> org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:222)
>       at 
> org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:293)
>       at 
> org.apache.wicket.util.tester.BaseWicketTester.processRequest(BaseWicketTester.java:718)
>       at 
> org.apache.wicket.util.tester.BaseWicketTester.processRequest(BaseWicketTester.java:657)
>       at 
> org.apache.wicket.util.tester.BaseWicketTester.processRequest(BaseWicketTester.java:629)
>       at 
> org.apache.wicket.util.tester.BaseWicketTester.startPage(BaseWicketTester.java:1262)
>       at 
> org.apache.wicket.util.tester.BaseWicketTester.startPage(BaseWicketTester.java:1235)
>       at 
> org.apache.wicket.extensions.markup.html.tree.HomePageTest.homepageRenders(HomePageTest.java:10)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:606)
>       at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>       at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>       at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>       at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>       at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>       at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>       at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>       at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>       at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>       at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>       at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>       at 
> org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
>       at 
> org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
>       at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
>       at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
>       at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
>       at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)
> {code}
> While the TreeTable (and other components from wicket15 tree) were moved as 
> they are considered unsupported, the current implementation of Wicket 7 seems 
> like a regression.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to