[
https://issues.apache.org/jira/browse/WICKET-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725361#comment-14725361
]
Patrick Davids commented on WICKET-5754:
----------------------------------------
Ähm, ok, possibly I understood this issue wrong...
Whats the improvement of this issue, if not also changing the constructors to
IModel<String> defaultValue?
from:
{code}
public StringResourceModel(final String resourceKey, final IModel<?>
model,
final String defaultValue, final Object... parameters)
{
this(resourceKey, null, model, defaultValue, parameters);
}
{code}
to:
{code}
public StringResourceModel(final String resourceKey, final IModel<?>
model,
final IModel<String> defaultValue, final Object... parameters)
{
this(resourceKey, null, model, defaultValue, parameters);
}
{code}
I was thinking this is the key improvement...
> (String)ResourceModel's defaultValue could be an IModel<String>
> ---------------------------------------------------------------
>
> Key: WICKET-5754
> URL: https://issues.apache.org/jira/browse/WICKET-5754
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.18.0
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 7.0.0-M5, 6.19.0, 6.20.0
>
>
> See http://markmail.org/message/4scedc7lpiupxjom
> By using IModel<String> instead of String the application may use a fallback
> that is i18n-ed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
