WICKET-6021 ConcurrentModificationException in MarkupContainer#iterator#next
Add a test case that exposes the CME in 7.1.0 Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/b9ec6670 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/b9ec6670 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/b9ec6670 Branch: refs/heads/lambdas Commit: b9ec66706ba57f27b7a849ed623915b494e5cf4d Parents: 63b1226 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Wed Nov 4 10:18:42 2015 +0100 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Wed Nov 4 10:18:42 2015 +0100 ---------------------------------------------------------------------- .../AddChildToParentInOnInitializeTest.java | 98 ++++++++++++++++++++ 1 file changed, 98 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/b9ec6670/wicket-core/src/test/java/org/apache/wicket/AddChildToParentInOnInitializeTest.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/java/org/apache/wicket/AddChildToParentInOnInitializeTest.java b/wicket-core/src/test/java/org/apache/wicket/AddChildToParentInOnInitializeTest.java new file mode 100644 index 0000000..336ecd4 --- /dev/null +++ b/wicket-core/src/test/java/org/apache/wicket/AddChildToParentInOnInitializeTest.java @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.wicket; + +import org.apache.wicket.markup.IMarkupResourceStreamProvider; +import org.apache.wicket.markup.html.WebMarkupContainer; +import org.apache.wicket.markup.html.WebPage; +import org.apache.wicket.util.resource.IResourceStream; +import org.apache.wicket.util.resource.StringResourceStream; +import org.apache.wicket.util.tester.WicketTestCase; +import org.junit.Test; + +/** + * https://issues.apache.org/jira/browse/WICKET-6021 + */ +public class AddChildToParentInOnInitializeTest extends WicketTestCase +{ + @Test + public void addChildToParentInOnInitialize() + { + tester.startPage(TestPage.class); + tester.assertRenderedPage(TestPage.class); + tester.assertComponent(TestPage.PARENT_ID + ':' + TestPage.FIRST_CHILD_ID, WebMarkupContainer.class); + tester.assertComponent(TestPage.PARENT_ID, Parent.class); + } + + public static class TestPage extends WebPage implements IMarkupResourceStreamProvider + { + public static final String FIRST_CHILD_ID = "firstChild"; + public static final String PARENT_ID = "parentContainer"; + public static final String SECOND_CHILD_ID = "thirdChild"; + public static final String THIRD_CHILD_ID = "fourthChild"; + + @Override + protected void onInitialize() + { + super.onInitialize(); + + final Parent parent = new Parent(); + add(parent); + + parent.addOrReplace(new WebMarkupContainer(TestPage.THIRD_CHILD_ID)); + } + + @Override + public IResourceStream getMarkupResourceStream(MarkupContainer container, Class<?> containerClass) + { + return new StringResourceStream("<html><head></head><body>" + + "<div wicket:id='"+ PARENT_ID +"'>" + + "<div wicket:id='"+FIRST_CHILD_ID+"'></div>" + + "<div wicket:id='"+ SECOND_CHILD_ID +"'></div>" + + "<div wicket:id='"+ THIRD_CHILD_ID +"'></div>" + + "</div>" + + "</body></html>"); + } + } + + private static class Parent extends WebMarkupContainer + { + public Parent() + { + super(TestPage.PARENT_ID); + + add(new WebMarkupContainer(TestPage.FIRST_CHILD_ID)); + add(new SecondChild()); + } + } + + private static class SecondChild extends WebMarkupContainer + { + public SecondChild() + { + super(TestPage.SECOND_CHILD_ID); + } + + @Override + protected void onInitialize() + { + super.onInitialize(); + + getParent().addOrReplace(new WebMarkupContainer(TestPage.THIRD_CHILD_ID)); + } + } +}
