[
https://issues.apache.org/jira/browse/WICKET-6042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035507#comment-15035507
]
ASF GitHub Bot commented on WICKET-6042:
----------------------------------------
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/143#issuecomment-161228258
I agree with Sven that `IModel<List>` is better than varargs.
We had issues with varargs in StringResourceModel and we broke the API in
7.x to improve it.
I also think it would be harder for the application to provide the
parameters as varargs, than as List.
Maybe we should deprecate the varargs signature in the other new components
? Or at least new constructor with List and wait for some feedback in the
coming months.
> Implementation of ExternalImage component
> -----------------------------------------
>
> Key: WICKET-6042
> URL: https://issues.apache.org/jira/browse/WICKET-6042
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 7.1.0, 8.0.0-M1
> Reporter: Tobias Soloschenko
> Assignee: Tobias Soloschenko
> Labels: features
>
> Like in the MediaComponent - Video for example
> (https://ci.apache.org/projects/wicket/apidocs/7.x/org/apache/wicket/markup/html/media/video/Video.html)
> the Image should be able to be configured with a String placed into the src
> attribute.
> Possible constructor to be used for that:
> Image(String id, IModel<?> model, String... srcs)
> As of comments the requirement changed a bit and a new implementation
> "ExternalImage" is the target of this ticket:
> http://apache-wicket.1842946.n4.nabble.com/Image-based-on-external-url-model-object-tt4672692.html#none
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
