wicket git commit: Add 'minlength' to or if Size.min() is bigger than 0</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=commits@wicket.apache.org&q=from:%22mgrigorov%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">mgrigorov</span></span></a></span> <span class="date"><a href="/search?l=commits@wicket.apache.org&q=date:20160206" rel="nofollow">Sat, 06 Feb 2016 06:35:28 -0800</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre>Repository: wicket Updated Branches: refs/heads/master 74ba1a8ab -> 13a763eda</pre><pre> Add 'minlength' to <input> or <textarea> if Size.min() is bigger than 0 Fixes #144 Project: <a rel="nofollow" href="http://git-wip-us.apache.org/repos/asf/wicket/repo">http://git-wip-us.apache.org/repos/asf/wicket/repo</a> Commit: <a rel="nofollow" href="http://git-wip-us.apache.org/repos/asf/wicket/commit/13a763ed">http://git-wip-us.apache.org/repos/asf/wicket/commit/13a763ed</a> Tree: <a rel="nofollow" href="http://git-wip-us.apache.org/repos/asf/wicket/tree/13a763ed">http://git-wip-us.apache.org/repos/asf/wicket/tree/13a763ed</a> Diff: <a rel="nofollow" href="http://git-wip-us.apache.org/repos/asf/wicket/diff/13a763ed">http://git-wip-us.apache.org/repos/asf/wicket/diff/13a763ed</a> Branch: refs/heads/master Commit: 13a763edae1e262296d9b240a65fbbfe2d16af6e Parents: 74ba1a8 Author: Martin Tzvetanov Grigorov <mgrigo...@apache.org> Authored: Sat Feb 6 15:33:47 2016 +0100 Committer: Martin Tzvetanov Grigorov <mgrigo...@apache.org> Committed: Sat Feb 6 15:33:47 2016 +0100 ---------------------------------------------------------------------- .../wicket/bean/validation/SizeTagModifier.java | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- <a rel="nofollow" href="http://git-wip-us.apache.org/repos/asf/wicket/blob/13a763ed/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SizeTagModifier.java">http://git-wip-us.apache.org/repos/asf/wicket/blob/13a763ed/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SizeTagModifier.java</a> ---------------------------------------------------------------------- diff --git a/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SizeTagModifier.java b/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SizeTagModifier.java index 1795dc4..9f2aa67 100644 --- a/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SizeTagModifier.java +++ b/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SizeTagModifier.java @@ -6,8 +6,8 @@ import org.apache.wicket.markup.ComponentTag; import org.apache.wicket.markup.html.form.FormComponent; /** - * A tag modifier that adds the {@code maxlength} attribute to the {@code input} tag with the max - * value from the {@link Size} constraint annotation. + * A tag modifier that adds the {@code maxlength} and {@code minlength} attributes to the {@code input} + * and {@code textarea} tag with the max/min value from the {@link Size} constraint annotation. * * @author igor * @@ -17,9 +17,19 @@ public class SizeTagModifier implements ITagModifier<Size> @Override public void modify(FormComponent<?> component, ComponentTag tag, Size annotation) { - if ("input".equalsIgnoreCase(tag.getName())) + if (hasLengthAttribute(tag.getName())) { tag.put("maxlength", annotation.max()); + + if (annotation.min() > 0) + { + tag.put("minlength", annotation.min()); + } } } + + protected boolean hasLengthAttribute(String tagName) + { + return "input".equalsIgnoreCase(tagName) || "textarea".equalsIgnoreCase(tagName); + } } </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg52527.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="thrd9.html#52532">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="mail9.html#52532">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg52533.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="wicket git commit: Add 'minlength' to <input> or <textarea> if Size.min() is bigger than 0"> <input type="hidden" name="msgid" value="6bf1fc4700f94794ad5a31264a2f5424@git.apache.org"> <input type="hidden" name="relpath" value="commits@wicket.apache.org/msg52532.html"> <input type="submit" value=" mgrigorov "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="commits@wicket.apache.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search commits"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/commits@wicket.apache.org/">commits - all messages</a></li> <li class="icons-about"><a href="/commits@wicket.apache.org/info.html">commits - about the list</a></li> <li class="icons-expand"><a href="/search?l=commits@wicket.apache.org&q=subject:%22wicket+git+commit%5C%3A+Add+%27minlength%27+to+%3Cinput%3E+or+%3Ctextarea%3E+if+Size.min%5C%28%5C%29+is+bigger+than+0%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg52527.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg52533.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">6bf1fc4700f94794ad5a31264a2f5424@git.apache.org</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9d517778f870cf47',t:'MTc3MjI5NzkwNg=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>