Repository: wicket Updated Branches: refs/heads/master 53ff55f16 -> 41776c423
Non functional cleanup - remove useless javadoc - remove implicit method modifiers in interfaces Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0113779d Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0113779d Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0113779d Branch: refs/heads/master Commit: 0113779d3a08992cd5116a11a84c4cef86fcc083 Parents: 53ff55f Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Thu Mar 17 21:07:50 2016 +0100 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Thu Mar 17 21:08:42 2016 +0100 ---------------------------------------------------------------------- .../repeater/data/table/HeaderlessColumn.java | 3 --- .../data/table/ISortableDataProvider.java | 4 +-- .../html/repeater/data/table/IStyledColumn.java | 2 +- .../data/table/filter/ChoiceFilter.java | 26 ++++++++++++++++++-- .../repeater/tree/table/AbstractTreeColumn.java | 3 --- .../html/repeater/tree/table/ITreeColumn.java | 2 +- .../repeater/tree/table/ITreeDataProvider.java | 4 +-- 7 files changed, 29 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/0113779d/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/HeaderlessColumn.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/HeaderlessColumn.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/HeaderlessColumn.java index 400e5bb..67998bc 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/HeaderlessColumn.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/HeaderlessColumn.java @@ -39,9 +39,6 @@ public abstract class HeaderlessColumn<T, S> extends AbstractColumn<T, S> super(new Model<>(" ")); } - /** - * @see org.apache.wicket.extensions.markup.html.repeater.data.table.AbstractColumn#getHeader(java.lang.String) - */ @Override public Component getHeader(final String componentId) { http://git-wip-us.apache.org/repos/asf/wicket/blob/0113779d/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ISortableDataProvider.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ISortableDataProvider.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ISortableDataProvider.java index c8c5414..a84ef9d 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ISortableDataProvider.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ISortableDataProvider.java @@ -31,6 +31,4 @@ import org.apache.wicket.markup.repeater.data.IDataProvider; */ public interface ISortableDataProvider<T, S> extends IDataProvider<T>, ISortStateLocator<S> { - - -} \ No newline at end of file +} http://git-wip-us.apache.org/repos/asf/wicket/blob/0113779d/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/IStyledColumn.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/IStyledColumn.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/IStyledColumn.java index ed7c124..968614b 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/IStyledColumn.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/IStyledColumn.java @@ -32,5 +32,5 @@ public interface IStyledColumn<T, S> extends IColumn<T, S> * * @return CSS class name */ - public String getCssClass(); + String getCssClass(); } http://git-wip-us.apache.org/repos/asf/wicket/blob/0113779d/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/ChoiceFilter.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/ChoiceFilter.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/ChoiceFilter.java index f4038cc..dfead34 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/ChoiceFilter.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/ChoiceFilter.java @@ -42,38 +42,60 @@ public class ChoiceFilter<T> extends AbstractFilter private final DropDownChoice<T> choice; /** + * Constructor. + * * @param id + * component id * @param model + * model for the drop down choice component * @param form + * filter form this component will be attached to * @param choices + * list of choices, see {@link DropDownChoice} * @param autoSubmit + * if true this filter will submit the form on selection change */ public ChoiceFilter(final String id, final IModel<T> model, final FilterForm<?> form, final IModel<? extends List<? extends T>> choices, final boolean autoSubmit) { - this(id, model, form, choices, new ChoiceRenderer<T>(), autoSubmit); + this(id, model, form, choices, new ChoiceRenderer<>(), autoSubmit); } /** + * Constructor + * * @param id + * component id * @param model + * model for the drop down choice component * @param form + * filter form this component will be attached to * @param choices + * list of choices, see {@link DropDownChoice} * @param autoSubmit + * if true this filter will submit the form on selection change */ public ChoiceFilter(final String id, final IModel<T> model, final FilterForm<?> form, final List<? extends T> choices, final boolean autoSubmit) { - this(id, model, form, Model.ofList(choices), new ChoiceRenderer<T>(), autoSubmit); + this(id, model, form, Model.ofList(choices), new ChoiceRenderer<>(), autoSubmit); } /** + * Constructor + * * @param id + * component id * @param model + * model for the drop down choice component * @param form + * filter form this component will be attached to * @param choices + * list of choices, see {@link DropDownChoice} * @param renderer + * choice renderer, see {@link DropDownChoice} * @param autoSubmit + * if true this filter will submit the form on selection change */ public ChoiceFilter(final String id, final IModel<T> model, final FilterForm<?> form, final List<? extends T> choices, final IChoiceRenderer<? super T> renderer, http://git-wip-us.apache.org/repos/asf/wicket/blob/0113779d/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/AbstractTreeColumn.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/AbstractTreeColumn.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/AbstractTreeColumn.java index 380ac61..fcbf501 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/AbstractTreeColumn.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/AbstractTreeColumn.java @@ -31,9 +31,6 @@ public abstract class AbstractTreeColumn<T, S> extends AbstractColumn<T, S> implements ITreeColumn<T, S> { - - /** - */ private static final long serialVersionUID = 1L; private TableTree<T, S> tree; http://git-wip-us.apache.org/repos/asf/wicket/blob/0113779d/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/ITreeColumn.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/ITreeColumn.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/ITreeColumn.java index 763ae5f..060182a 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/ITreeColumn.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/ITreeColumn.java @@ -34,5 +34,5 @@ public interface ITreeColumn<T, S> extends IColumn<T, S> * @param t * tree */ - public void setTree(TableTree<T, S> t); + void setTree(TableTree<T, S> t); } http://git-wip-us.apache.org/repos/asf/wicket/blob/0113779d/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/ITreeDataProvider.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/ITreeDataProvider.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/ITreeDataProvider.java index 9e1bf3b..1fe8f80 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/ITreeDataProvider.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/ITreeDataProvider.java @@ -36,5 +36,5 @@ public interface ITreeDataProvider<T> extends IDataProvider<T> * node */ @Override - public NodeModel<T> model(T node); -} \ No newline at end of file + NodeModel<T> model(T node); +}
