[ 
https://issues.apache.org/jira/browse/WICKET-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389409#comment-15389409
 ] 

Martin Grigorov commented on WICKET-6214:
-----------------------------------------

I don't have time to check now but AFAIR one of the jQuery core devs 
recommended to not try to "fix" already "fixed" event. I.e. event passed by 
jQuery event listener should not be fixed.

> ModalWindow broken on IE
> ------------------------
>
>                 Key: WICKET-6214
>                 URL: https://issues.apache.org/jira/browse/WICKET-6214
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.23.0, 6.24.0
>            Reporter: Sven Meier
>            Assignee: Martin Grigorov
>            Priority: Minor
>
> Since WICKET-6108 wicket-event-jquery.js no longer fixes passed in events:
> {code}
>       fix: function (evt) {
> -             var evnt = evt || window.event;
> -             return jQuery.event.fix(evnt);
> +             return evt || jQuery.event.fix(window.event);
>       },
> {code}
> But modal.js directly invokes {{Wicket.Event#stop()}}:
> {code}
>       onmousedown=\"Wicket.Event.stop(event);\"
> {code}
> Thus the event is not 'fixed', but {{#stopPropagation()}} is called on it:
> {code}
>       stop: function (evt, immediate) {
>               evt = Wicket.Event.fix(evt);
>               if (immediate) {
>                       evt.stopImmediatePropagation();
>               } else {
>                       evt.stopPropagation();
>               }
>               return evt;
>       },
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to