[ 
https://issues.apache.org/jira/browse/WICKET-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409219#comment-15409219
 ] 

Bas Huisman commented on WICKET-6185:
-------------------------------------

Hi [~bitstorm], I think this commit introduced a bug.

In line Border.java:679 (Wicket .7.4.0) the statement

{{containerClass.equals(getClass())}}

returns false when containerClass is an anonymous inner class.

If the line:

{{boolean isBorderBodyTag = containerClass == null || 
containerClass.equals(getClass());}}

is changed to:

{{boolean isBorderBodyTag = containerClass == null || 
containerClass.isAssignableFrom(getClass());}}

all is fine again.

Do you want a PR for this?

> Border body not reachable for visitors
> --------------------------------------
>
>                 Key: WICKET-6185
>                 URL: https://issues.apache.org/jira/browse/WICKET-6185
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 7.3.0
>            Reporter: Martin Grigorov
>            Assignee: Andrea Del Bene
>             Fix For: 8.0.0-M1, 7.4.0
>
>         Attachments: myproject2.zip
>
>
> After change 
> https://github.com/apache/wicket/commit/f14e03f84454101fe6569bd1a1979b5835835246#diff-d1bbf49cc52782243da7166b955deca5L169
>  made for WICKET-5988 MarkupContainer#visitChildren() won't visit the 
> Border's body unless it is manually added to the Border (i.e. as a child).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to