Cache the contents of headerBuffer.getContents() as a local var
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/f1cb06c3 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/f1cb06c3 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/f1cb06c3 Branch: refs/heads/master Commit: f1cb06c3692111c4eddbb2fab3cdeb58d8491b1f Parents: 451e5c3 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Sun Aug 28 18:38:34 2016 +0200 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Sun Aug 28 18:39:36 2016 +0200 ---------------------------------------------------------------------- .../main/java/org/apache/wicket/page/XmlPartialPageUpdate.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/f1cb06c3/wicket-core/src/main/java/org/apache/wicket/page/XmlPartialPageUpdate.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/page/XmlPartialPageUpdate.java b/wicket-core/src/main/java/org/apache/wicket/page/XmlPartialPageUpdate.java index 8021285..28c2ffa 100644 --- a/wicket-core/src/main/java/org/apache/wicket/page/XmlPartialPageUpdate.java +++ b/wicket-core/src/main/java/org/apache/wicket/page/XmlPartialPageUpdate.java @@ -150,14 +150,15 @@ public class XmlPartialPageUpdate extends PartialPageUpdate @Override protected void writeHeaderContribution(Response response) { - if (headerBuffer.getContents().length() != 0) + CharSequence contents = headerBuffer.getContents(); + if (Strings.isEmpty(contents) == false) { response.write("<header-contribution>"); // we need to write response as CDATA and parse it on client, // because konqueror crashes when there is a <script> element response.write("<![CDATA[<head xmlns:wicket=\"http://wicket.apache.org\";>"); - response.write(encode(headerBuffer.getContents())); + response.write(encode(contents)); response.write("</head>]]>"); response.write("</header-contribution>"); }
