Repository: wicket Updated Branches: refs/heads/wicket-7.x 6c6f08a30 -> 6637e363b
WICKET-6245 Remove 'final' modifier for the modified methods because this breaks Clirr (correctly or not) Discussion: https://mail-archives.apache.org/mod_mbox/wicket-dev/201609.mbox/%3CCAB63Y-drhdSVkNX+ARz51bDBGBX_req_d6DGRNW=67nr5rb...@mail.gmail.com%3E Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/6637e363 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/6637e363 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/6637e363 Branch: refs/heads/wicket-7.x Commit: 6637e363bec2eb49de0d2edce3505a1fdb7586bd Parents: 6c6f08a Author: Martin Tzvetanov Grigorov <mgrigo...@apache.org> Authored: Tue Sep 27 16:33:54 2016 +0200 Committer: Martin Tzvetanov Grigorov <mgrigo...@apache.org> Committed: Tue Sep 27 16:37:29 2016 +0200 ---------------------------------------------------------------------- .../http/CsrfPreventionRequestCycleListener.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/6637e363/wicket-core/src/main/java/org/apache/wicket/protocol/http/CsrfPreventionRequestCycleListener.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/CsrfPreventionRequestCycleListener.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/CsrfPreventionRequestCycleListener.java index 72fa4ee..814e90d 100644 --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/CsrfPreventionRequestCycleListener.java +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/CsrfPreventionRequestCycleListener.java @@ -322,7 +322,7 @@ public class CsrfPreventionRequestCycleListener extends AbstractRequestCycleList * The handler to unwrap * @return the deepest handler that does not implement {@code IRequestHandlerDelegate} */ - protected final IRequestHandler unwrap(IRequestHandler handler) + protected IRequestHandler unwrap(IRequestHandler handler) { while (handler instanceof IRequestHandlerDelegate) handler = ((IRequestHandlerDelegate)handler).getDelegateHandler(); @@ -461,7 +461,7 @@ public class CsrfPreventionRequestCycleListener extends AbstractRequestCycleList * the contents of the {@code Origin} or {@code Referer} HTTP header * @return {@code true} when the source domain was whitelisted */ - protected final boolean isWhitelistedHost(final String sourceUri) + protected boolean isWhitelistedHost(final String sourceUri) { try { @@ -625,7 +625,7 @@ public class CsrfPreventionRequestCycleListener extends AbstractRequestCycleList * @param page * the page that is targeted with this request */ - protected final void whitelistedHandler(HttpServletRequest request, String origin, + protected void whitelistedHandler(HttpServletRequest request, String origin, IRequestablePage page) { onWhitelisted(request, origin, page); @@ -662,7 +662,7 @@ public class CsrfPreventionRequestCycleListener extends AbstractRequestCycleList * @param page * the page that is targeted with this request */ - protected final void matchingOrigin(HttpServletRequest request, String origin, + protected void matchingOrigin(HttpServletRequest request, String origin, IRequestablePage page) { onMatchingOrigin(request, origin, page); @@ -701,7 +701,7 @@ public class CsrfPreventionRequestCycleListener extends AbstractRequestCycleList * @param page * the page that is targeted with this request */ - protected final void allowHandler(HttpServletRequest request, String origin, + protected void allowHandler(HttpServletRequest request, String origin, IRequestablePage page) { onAllowed(request, origin, page); @@ -737,7 +737,7 @@ public class CsrfPreventionRequestCycleListener extends AbstractRequestCycleList * @param page * the page that is targeted with this request */ - protected final void suppressHandler(HttpServletRequest request, String origin, + protected void suppressHandler(HttpServletRequest request, String origin, IRequestablePage page) { onSuppressed(request, origin, page); @@ -774,7 +774,7 @@ public class CsrfPreventionRequestCycleListener extends AbstractRequestCycleList * @param page * the page that is targeted with this request */ - protected final void abortHandler(HttpServletRequest request, String origin, + protected void abortHandler(HttpServletRequest request, String origin, IRequestablePage page) { onAborted(request, origin, page);
