[
https://issues.apache.org/jira/browse/WICKET-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624638#comment-15624638
]
ASF subversion and git services commented on WICKET-6260:
---------------------------------------------------------
Commit 8590467fd03efb570e989dacd9455eb69d3770ce in wicket's branch
refs/heads/master from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8590467 ]
WICKET-6260 let WebRequest detect Ajax request
WebRequest#isAjax() no longer touches the request body, thus it can safely be
asked
> Revert Ajax detection needed for character encoding to WebRequest.isAjax()
> --------------------------------------------------------------------------
>
> Key: WICKET-6260
> URL: https://issues.apache.org/jira/browse/WICKET-6260
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0
> Reporter: Sven Meier
> Assignee: Sven Meier
> Priority: Minor
> Fix For: 6.26, 7.6.0, 8.0.0-M3
>
>
> This issue has some history:
> - with WICKET-3908 the character encoding became dependent on whether the
> request is sent via Ajax
> - with WICKET-3914 the Ajax check was limited to the request header,
> preventing body parameters being read before the character encoding was set
> - since WICKET-6135 WebRequest.isAjax() no longer accesses body parameters.
> Thus I conclude that we can safely revert the changes of WICKET-3914 and just
> use WebRequest.isAjax() again in WebApplication.createWebRequest().
> Benefits:
> - removes duplicated logic in WebApplication.createWebRequest()
> - allows WebRequest to identify Ajax request by different means (as
> advertised in the Javadoc of #isAjax())
> - makes WICKET-6144 effective for all access to the 'Wicket-Ajax'
> header/parameter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
