[ 
https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15698484#comment-15698484
 ] 

ASF GitHub Bot commented on WICKET-6287:
----------------------------------------

Github user klopfdreh commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/193#discussion_r89677866
  
    --- Diff: pom.xml ---
    @@ -447,6 +447,12 @@
                                <type>jar</type>
                        </dependency>
                        <dependency>
    +                   <groupId>com.tdunning</groupId>
    +                   <artifactId>json</artifactId>
    +                           <version>1.2-SNAPSHOT</version>
    --- End diff --
    
    Hi @bitstorm ,
    
    1.2 has been just released. 😄 
    
    Anyway the were two reasons why to wait for this version.
    
    1. The slash / should only be escaped after a "<" bracket 
(https://github.com/tdunning/open-json/commit/e1541126bf3206fa7a2b243f3791e274822128c1)
    2. JSONFunction was not implemented yet. 
(https://github.com/tdunning/open-json/commit/174ab93ac966f0213ac4a4bd3ac5b17e0920a7c8)
 - this is required for json like this: { "mykey": window.myfunction() }
    
    We can switch the version to 1.2 and it should work with this PR.
    
    kind regards
    
    Tobias


> Switch from json.org to open-json
> ---------------------------------
>
>                 Key: WICKET-6287
>                 URL: https://issues.apache.org/jira/browse/WICKET-6287
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket, wicket-atmosphere, wicket-extensions
>    Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0
>            Reporter: Tobias Soloschenko
>            Assignee: Tobias Soloschenko
>            Priority: Minor
>              Labels: license
>             Fix For: 6.26, 7.6.0, 8.0.0-M3
>
>
> Because of license issues it is required to switch from json.org:
> https://github.com/stleary/JSON-java
> to open-json:
> https://github.com/tdunning/open-json
> For more information see:
> http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to