[
https://issues.apache.org/jira/browse/WICKET-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856928#comment-15856928
]
ASF GitHub Bot commented on WICKET-5247:
----------------------------------------
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/210#discussion_r99945970
--- Diff:
wicket-core/src/test/java/org/apache/wicket/core/request/mapper/MountedMapperTest.java
---
@@ -714,7 +714,7 @@ public boolean isNewPageInstance()
@Test
public void placeholderEncode4()
{
- PageProvider provider = new PageProvider(new MockPage())
+ PageProvider provider = new PageProvider(MockPage.class)
--- End diff --
I didn't understand you.
```java
/**
* WICKET-5247 page instantiated without required parameters won't be
mapped
*/
@Test
public void placeholderEncode4()
{
PageProvider provider = new PageProvider(new MockPage())
{
@Override
public boolean isNewPageInstance()
{
return false;
}
};
provider.setPageSource(context);
IRequestHandler handler = new
RenderPageRequestHandler(provider);
Url url = placeholderEncoder.mapHandler(handler);
assertNull(url);
}
```
The test setups a PageProvider and uses it. There is no replacement after.
By making this change I think we don't test the same as what broke in
WICKET-5247.
> Broken Link in Tomcat because of Page Mount
> -------------------------------------------
>
> Key: WICKET-5247
> URL: https://issues.apache.org/jira/browse/WICKET-5247
> Project: Wicket
> Issue Type: Bug
> Components: wicket-quickstart
> Affects Versions: 6.8.0
> Environment: Tomcat 7.0.41
> Reporter: Martin Wischnewski
> Assignee: Sven Meier
> Priority: Minor
> Fix For: 6.9.0, 1.5.11, 7.0.0-M1
>
> Attachments: quickstart.zip, webapp.war
>
>
> I post this message on the user mailing List
> (http://apache-wicket.1842946.n4.nabble.com/Broken-Link-in-Tomcat-because-of-Page-Mount-tt4659663.html)
> and Martin Grigorov asked me, to create a ticket on Jira.
> Broken Link in Tomcat because of Page Mount
> Following situation:
> -I have a Wicket Application(6.8.0) which runs under the context "webapp" on
> a Tomcat 7.0.41
> -I mount a Page with two parameters (this is important) in the
> WicketApplication.
> mountPage("/mount/${parameter1}/${parameter2}", MountedPage.class);
> -The mounted Page(MountedPage.class) has only a simple Link
> -There are two links on the HomePage to the mounted Page.
> They are declared as follows:
>
> add(new Link<Void>("link") {
> @Override
> public void onClick() {
> setResponsePage(MountedPage.class,
> linkParameters);
> }
> });
> add(new Link<Void>("brokenLink") {
> @Override
> public void onClick() {
> setResponsePage(new
> MountedPage(linkParameters));
> }
> });
>
> I deploy this Application as a war file on a Tomcat under the context
> "webapp".
> When I call the first Link on the HomePage and then the Link on the mounted
> Page, everything works fine.
> But if I call the second Link and then the Link on the mounted Page, the link
> is broken.
> The context is missing in the generated link
> http://localhost:8080/wicket/bookmarkable/com.mycompany.LinkedPage
> Does anyone have an idea, why the second link does not work on Tomcat?
> I add a Quickstart and the war file as attachment.
> Ps: Both links works fine in Jetty.
> Pss:If I remove the mount command, both links will work in Tomcat too.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
