Repository: wicket Updated Branches: refs/heads/WICKET-4201-improved-page-provider 1ec36a2e7 -> 0afd78c43
WICKET-4201 removing unnecessary runtime exception from PageProvider#doesProvideNewPage() Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0afd78c4 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0afd78c4 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0afd78c4 Branch: refs/heads/WICKET-4201-improved-page-provider Commit: 0afd78c43409ec38428b4ab100547ac018913804 Parents: 1ec36a2 Author: Pedro Henrique Oliveira dos Santos <[email protected]> Authored: Tue Feb 7 21:29:09 2017 -0200 Committer: Pedro Henrique Oliveira dos Santos <[email protected]> Committed: Tue Feb 7 21:29:09 2017 -0200 ---------------------------------------------------------------------- .../wicket/core/request/handler/PageProvider.java | 4 ---- .../apache/wicket/request/handler/PageProviderTest.java | 12 ++---------- 2 files changed, 2 insertions(+), 14 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/0afd78c4/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java index 5728628..dccd699 100644 --- a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java +++ b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java @@ -232,10 +232,6 @@ public class PageProvider implements IPageProvider, IClusterable @Override public final boolean doesProvideNewPage() { - if (provision == null) - { - throw new IllegalStateException("Page instance not yet resolved"); - } return getProvision().doesProvideNewPage(); } http://git-wip-us.apache.org/repos/asf/wicket/blob/0afd78c4/wicket-core/src/test/java/org/apache/wicket/request/handler/PageProviderTest.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/java/org/apache/wicket/request/handler/PageProviderTest.java b/wicket-core/src/test/java/org/apache/wicket/request/handler/PageProviderTest.java index f5af25a..622b48b 100644 --- a/wicket-core/src/test/java/org/apache/wicket/request/handler/PageProviderTest.java +++ b/wicket-core/src/test/java/org/apache/wicket/request/handler/PageProviderTest.java @@ -198,21 +198,13 @@ public class PageProviderTest extends WicketTestCase public void testPageProperties_bookmarkable() { PageProvider provider = new PageProvider(StatelessPageTest.class); + assertTrue(provider.doesProvideNewPage()); assertFalse(provider.hasPageInstance()); - try - { - provider.doesProvideNewPage(); - fail("expected illegal state exception"); - } - catch (IllegalStateException e) - { - // expected - } provider.getPageInstance(); - assertTrue(provider.hasPageInstance()); assertTrue(provider.doesProvideNewPage()); + assertTrue(provider.hasPageInstance()); } @Test
