[ 
https://issues.apache.org/jira/browse/WICKET-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881817#comment-15881817
 ] 

Pedro Santos commented on WICKET-6318:
--------------------------------------

> For example this won't work with LazyModel any longer

I looked over the the failing tests and they were failing to get a property 
expression resolver because they were running in a thread with no Wicket 
application set to provide one. I fixed it just by extending from WicketTestCase

>>I've just tested the identical setup for LazyModel and it works perfectly. 
>>Why shouldn't it?
>I'm not familiar with LazyModel, will take a better look since the new 
>IPropertyExpressionResolver should enable it work >fine without 
>IPropertyReflectionAwareModel.

I added a test case exemplifying why it shouldn't work at LazyModelTest in the 
branch "lazymodel-without-IPRAM" [1]

> After all as long as a model implements IPropertyReflectionAwareModel, all 
> consumers of this interface should work fine.

LazyModel isn't even testing for IPRAM reflection information, and it's correct 
by ignoring them. A single method can be responsible for multiple bean 
properties, e.g. JSONObject, and both IObjectTypeAwareModel and 
IObjectClassAwareModel should be more than enough to provide LazyModel the 
model type.

1 - 
https://github.com/wicketstuff/core/commit/7c21f93924fd65968c9b655c09bd66e78d940760

> To make PropertyResolver a configurable implementation
> ------------------------------------------------------
>
>                 Key: WICKET-6318
>                 URL: https://issues.apache.org/jira/browse/WICKET-6318
>             Project: Wicket
>          Issue Type: Sub-task
>          Components: wicket
>            Reporter: Pedro Santos
>
> To enable users to select each property resolver will be used, so if the new 
> implementation shows problematic it can be switched back to the a Wicket's < 
> 7 one.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to