[
https://issues.apache.org/jira/browse/WICKET-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937859#comment-15937859
]
Martin Grigorov commented on WICKET-6286:
-----------------------------------------
[~svenmeier] I'm checking how the support for "failure" works for NewWindow.
I see that again you use the content to detect whether it is a failure:
{code}
html: function() {
return jQuery(wo ? wo.document : undefined).find('body').html();
},
{code}
I.e. if the response is anything but HTML (e.g. PDF, Excel, ...) then it is a
success, but if it is HTML content then it is a failure. I guess this is done
because in case of an error Wicket renders the configured InternalErrorPage.
If I understand it correctly then I think we should add a note in the javadocs
that the failure detection won't work in case the application renders HTML in
the download response. I guess no one will use AjaxDownload to render HTML but
who knows.
> Would be good to have AjaxDownload available out of the box
> ------------------------------------------------------------
>
> Key: WICKET-6286
> URL: https://issues.apache.org/jira/browse/WICKET-6286
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-extensions
> Affects Versions: 8.0.0-M2, 7.5.0
> Reporter: Maxim Solodovnik
> Assignee: Sven Meier
> Labels: patch
> Fix For: 8.0.0-M5
>
>
> Currently every project need to create own AjaxDownload component based on
> the Wiki example.
> Unfortunately this component has some issues with WebSockets
> Discussion: http://markmail.org/message/gizsnqh2qgypcgri
> PRs:
> https://github.com/apache/wicket/pull/190
> https://github.com/apache/wicket/pull/191
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
