[
https://issues.apache.org/jira/browse/WICKET-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941841#comment-15941841
]
ASF subversion and git services commented on WICKET-4201:
---------------------------------------------------------
Commit d2a809262811a7696660425dd80cdd9d0c55ed4d in wicket's branch
refs/heads/master from Pedro Henrique Oliveira dos Santos
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=d2a8092 ]
WICKET-4201 removing the page expired exception from page provider and using
its API to determine such state throughout the code
> IPageProvider and its implementations need to be improved
> ---------------------------------------------------------
>
> Key: WICKET-4201
> URL: https://issues.apache.org/jira/browse/WICKET-4201
> Project: Wicket
> Issue Type: Task
> Components: wicket
> Affects Versions: 1.5.0, 1.5.1, 1.5.2
> Reporter: Emond Papegaaij
> Assignee: Pedro Santos
>
> During the development op 1.5, IPageProvider and its implementations have
> become a bit of a mess. The interface is not clearly defined. One of the
> biggest problems is that several methods can throw exceptions and there is no
> way of knowing which method will throw which exception and when. It should
> always be clear what exceptions to expect. For example, getPage can throw a
> PageExpiredException, but getPageClass cannot, it should return null if no
> page class is set. Perhaps, it's even better to never throw exceptions at
> all. Also, the various introspection methods are not very well defined and
> make it almost impossible to come up with an alternative implementation of
> the interface (which, IMHO is a sign of a broken API).
> Changing this interface is not an option for 1.5, but looking at the number
> of subtle bugs that came from this part of the code, it should really be
> considered for wicket.next.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
