Repository: wicket
Updated Branches:
  refs/heads/WICKET-6347-detachable-renderers 0bc929d71 -> 24da5e48b


WICKET-6347 renderer might be null

if #newEditor() doesn't create AbstractChoice, the renderer might actually be 
null


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/24da5e48
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/24da5e48
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/24da5e48

Branch: refs/heads/WICKET-6347-detachable-renderers
Commit: 24da5e48b3410ab46dced342cdd08a15831069bc
Parents: 0bc929d
Author: Sven Meier <[email protected]>
Authored: Mon Mar 27 18:38:00 2017 +0200
Committer: Sven Meier <[email protected]>
Committed: Mon Mar 27 18:38:00 2017 +0200

----------------------------------------------------------------------
 .../extensions/ajax/markup/html/AjaxEditableChoiceLabel.java  | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/24da5e48/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableChoiceLabel.java
----------------------------------------------------------------------
diff --git 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableChoiceLabel.java
 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableChoiceLabel.java
index 221a42f..5dfa693 100644
--- 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableChoiceLabel.java
+++ 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableChoiceLabel.java
@@ -325,8 +325,11 @@ public class AjaxEditableChoiceLabel<T> extends 
AjaxEditableLabel<T>
                        choices.detach();
                }
                
-               renderer.detach();
+               if (renderer != null)
+               {
+                       renderer.detach();
+               }
                
                super.onDetach();
        }
-}
+}
\ No newline at end of file

Reply via email to