Repository: wicket Updated Branches: refs/heads/master 11df645ad -> d89357404
WICKET-6366 check input still on page this closes #220 Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d8935740 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d8935740 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d8935740 Branch: refs/heads/master Commit: d89357404bbef4ed7b5bd8400136ad34512f7ff5 Parents: 11df645 Author: Sven Meier <[email protected]> Authored: Mon Jun 5 14:20:20 2017 +0200 Committer: Sven Meier <[email protected]> Committed: Mon Jun 5 14:23:21 2017 +0200 ---------------------------------------------------------------------- .../html/autocomplete/wicket-autocomplete.js | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/d8935740/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js index 0a4f8b0..5fa8d2e 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js @@ -357,9 +357,14 @@ attrs.pre = attrs.pre || []; attrs.pre.push(function (attributes) { + var input = Wicket.$(elementId); + if (!input) { + // WICKET-6366 input might no longer be on page + return false; + } + var activeIsInitial = (document.activeElement === initialElement); - var elementVal = Wicket.$(elementId).value; - var hasMinimumLength = elementVal.length >= minInputLength; + var hasMinimumLength = input.value.length >= minInputLength; var result = hasMinimumLength && activeIsInitial; @@ -682,8 +687,12 @@ function scheduleEmptyCheck() { window.setTimeout(function() { var input=Wicket.$(elementId); - if (!cfg.showListOnEmptyInput && (input.value === null || input.value === "")) { - hideAutoComplete(); + + // WICKET-6366 input might no longer be on page + if (input) { + if (!cfg.showListOnEmptyInput && (input.value === null || input.value === "")) { + hideAutoComplete(); + } } }, 100); }
