[ 
https://issues.apache.org/jira/browse/WICKET-6412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089880#comment-16089880
 ] 

Martin Grigorov commented on WICKET-6412:
-----------------------------------------

Yes, I was confused that current IModel#orElse() returns T, but it actually 
returns IModel<T>.

Thinking more on it I actually like it the way it is!
... = new MyComponent("id", someModel.orElse("N/A"))

If one wants to get the value in the middle of her logic: 
model.orElse(default).getObject()

No need to add any new overloads!
**Maybe** our API is better than j.u.Optional! **Maybe**! 

> Model#orElse behavior is inconsistent!
> --------------------------------------
>
>                 Key: WICKET-6412
>                 URL: https://issues.apache.org/jira/browse/WICKET-6412
>             Project: Wicket
>          Issue Type: Improvement
>    Affects Versions: 8.0.0-M6
>            Reporter: Jarosław
>            Assignee: Sven Meier
>
> Dear Wicket Devs,
> I was very confused by Model#orElse method.
> Model and Optional have similar methods and these methods behave the same:
> {code}
> Optional<Integer> _optional = Optional.ofNullable("1").map(Integer::parseInt);
> IModel<Integer> _model = Model.of("1").map(Integer::parseInt);
> {code}
> Unfortunately "orElse" behavior is totally confusing!
> {code}
> Integer integer = _optional.orElse(0);
> IModel<Integer> integerIModel = _model.orElse(0); //WRONG!
> {code}
> It should return a Model's Object instead of Model itself!
> This definitely break the least surprise rule, so can you please change that 
> before Wicket8 final release?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to