[ 
https://issues.apache.org/jira/browse/WICKET-6419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092194#comment-16092194
 ] 

ASF subversion and git services commented on WICKET-6419:
---------------------------------------------------------

Commit e75cb25605ac64e4b2f6bc149f7f2e1243f824cb in wicket's branch 
refs/heads/WICKET-6419 from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e75cb25 ]

WICKET-6419 Localization of PageParameters

Explicitly set the default locale to ENGLISH so that the test doesn't fail on 
developer machines with DE locale.


>  Localization of PageParameters 
> --------------------------------
>
>                 Key: WICKET-6419
>                 URL: https://issues.apache.org/jira/browse/WICKET-6419
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 7.7.0
>            Reporter: Ravi Knox
>            Assignee: Martin Grigorov
>             Fix For: 8.0.0
>
>
> It concerns the reading of PageParameters. They all use the StringValue 
> constructor without passing the Session locale.
> The StringValue will in turn use the systems locale.
> So when I retrieve a _en formatted number (1.000) from my GET-Params, I get a 
> wrong number (1) because my Server runs on a _de machine where a dot is a 
> decimal delimeter.
> I can work around that by again creating a StringValue based on my previous 
> StringValue, but with passing the Session locale.
> Shouldn't it pass the session's locale in first place?
> See 
> [here|https://github.com/apache/wicket/blob/master/wicket-request/src/main/java/org/apache/wicket/request/mapper/parameter/PageParameters.java#L167]
>  for the PageParameter implementation and 
> [here|https://github.com/apache/wicket/blob/master/wicket-util/src/main/java/org/apache/wicket/util/string/StringValue.java#L186]
>  for the StringValue implementation.
> See also:
> http://apache-wicket.1842946.n4.nabble.com/Localization-of-PageParameters-td4678221.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to