[ 
https://issues.apache.org/jira/browse/WICKET-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115563#comment-16115563
 ] 

ASF GitHub Bot commented on WICKET-6438:
----------------------------------------

GitHub user ozeray reopened a pull request:

    https://github.com/apache/wicket/pull/229

    WICKET-6438 - 8.x reference guide needs a few minor improvements

    Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning 
during maven packaging phase:
    WARNING: image to embed not found or not readable: 
F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg
    
    Minor fix in contributing.adoc: Revised the generated document target 
directory for the user guide documentation.
    
    Cropped top and bottom blank parts in comsysto-logo.png to have the 
Introduction page fit in one page in PDF. Made minor changes in 
helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ozeray/wicket master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #229
    
----
commit 9e323be5eecba1052414e22f4d3505bbc5863238
Author: ozeray <ahmetoze...@yahoo.com>
Date:   2017-08-06T00:12:03Z

    A few minor improvements
    
    Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning 
during maven packaging phase:
    WARNING: image to embed not found or not readable: 
F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg
    
    Minor fix in contributing.adoc: Revised the generated document target 
directory for the user guide documentation.
    
    Cropped top and bottom blank parts in comsysto-logo.png to have the 
Introduction page fit in one page in PDF. Made minor changes in 
helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.

commit 149134dbea8bb99253853338f471a2dab207733c
Author: ozeray <ahmetoze...@yahoo.com>
Date:   2017-08-06T00:42:04Z

    Added github forking step into Contribution section.
    
    Made a few minor changes to adapt with this new step.

----


> 8.x reference guide needs a few minor improvements
> --------------------------------------------------
>
>                 Key: WICKET-6438
>                 URL: https://issues.apache.org/jira/browse/WICKET-6438
>             Project: Wicket
>          Issue Type: Improvement
>          Components: guide
>    Affects Versions: 8.0.0
>            Reporter: Ahmet Yaşar Özer
>            Assignee: Andrea Del Bene
>            Priority: Minor
>              Labels: documentation
>
> Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during 
> maven packaging phase:
> WARNING: image to embed not found or not readable: 
> F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg
> Minor fix in contributing.adoc: Revised the generated document target 
> directory for the user guide documentation.
> Cropped top and bottom blank parts in comsysto-logo.png to have the 
> Introduction page fit in one page in PDF. Made minor changes in 
> helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to