[
https://issues.apache.org/jira/browse/WICKET-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162574#comment-16162574
]
ASF GitHub Bot commented on WICKET-6465:
----------------------------------------
Github user papegaaij commented on the issue:
https://github.com/apache/wicket/pull/233
I don't see why the current implementation uses `AtomicBoolean`. The
current implementation could just as well use a normal boolean. If we need to
take concurrent access into account (and I think we do), we should probably use
a `ThreadLocal`. Of course this assumes that the servlet container will call
(un)bound from the same thread, but the current implementation already has that
assumption. If a container decides to make the calls async, there is no way of
telling if it will happen between the setting and clearing of the boolean.
> PageStore not cleared at session end
> ------------------------------------
>
> Key: WICKET-6465
> URL: https://issues.apache.org/jira/browse/WICKET-6465
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 7.8.0
> Environment: Tomcat
> Reporter: Franta Mejta
> Assignee: Emond Papegaaij
> Priority: Critical
> Attachments: WICKET-6465.patch
>
>
> WICKET-6387 causes the page store not to be cleared at logout on Tomcat. The
> problem is that tomcat does not call {{valueUnbound}} or {{valueBound}} when
> an attribute is set to the current value (new == old).
> https://github.com/apache/tomcat/blob/e28b35c9e40aeb4b7ac52a98f07ad965630e2766/java/org/apache/catalina/session/StandardSession.java#L1424
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
