[
https://issues.apache.org/jira/browse/WICKET-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266776#comment-16266776
]
ASF GitHub Bot commented on WICKET-6501:
----------------------------------------
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/248
[WICKET-6501] storeSettings.isAsynchronous() is honored
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket WICKET-6501-store-settings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #248
----
commit 383c40f2557e78ac852ca4ea4300901281902435
Author: Maxim Solodovnik <[email protected]>
Date: 2017-11-27T13:08:40Z
[WICKET-6501] storeSettings.isAsynchronous() is honored
----
> DefaultPageManagerProvider does not honour
> StoreSettings.setAsynchronous(false)
> -------------------------------------------------------------------------------
>
> Key: WICKET-6501
> URL: https://issues.apache.org/jira/browse/WICKET-6501
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 8.0.0-M8
> Reporter: Greg Johnson
> Assignee: Maxim Solodovnik
> Priority: Minor
>
> StoreSettings.setAsynchronous(false) does not prevent pageStore from being
> wrapped with AsynchronousPageStore
> DefaultPageManagerProvider.java:
> if (pageStore.canBeAsynchronous())
> {
> pageStore = new AsynchronousPageStore(pageStore, capacity);
> }
> Suggest:
> if (pageStore.canBeAsynchronous() && storeSettings.isAsynchronous())
> {
> pageStore = new AsynchronousPageStore(pageStore, capacity);
> }
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
