[
https://issues.apache.org/jira/browse/WICKET-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301327#comment-16301327
]
Kamil commented on WICKET-6507:
-------------------------------
Javadoc is clear about it. It states:
{code}
Constructs a collector that will collect messages from Session and specified
container
{code}
I must admit, that I didn't read it, because I just blindly followed
(copy-pasted) the advice from dev's group, I'm sorry :(
But the problem here is different:
If "FedbackCollector" is named "SessionFeedbackCollector" then it would be
clear, that session is taken into account all the time, but in this situation I
find this misleading.
In my opinion If one is creating FeedbackCollector using the constructor with
specific component then this component should be used instead of session (thus
"includeSession" should be set to false by default)
But you probably wouldn't change it, that is why I suggested two-parameter
contructor.
> Please add additional constructor to FeedbackCollector
> ------------------------------------------------------
>
> Key: WICKET-6507
> URL: https://issues.apache.org/jira/browse/WICKET-6507
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 8.0.0-M8
> Reporter: Kamil
> Assignee: Andrea Del Bene
> Attachments: wicket race condition.gif, wicket race condition.mp4,
> wicket-race-condition-quickstart.zip
>
>
> This bug is weird, but it has probably something to do with race condition.
> I recorded a screencast, so you can clearly see what is wrong.
> When I have some computation directly in "onSubmit" method, then JS alert is
> invoked properly. If I try to move computation somewhere else (here I just do
> "extract method" refactoring, but in real life this operation would be
> executed in some top-level panel or service) then JS is not being invoked
> (good thing: this behavior is consistent across all of my tries)!
> I attached quickstart so you can try it by yourself. The lines I'm extracting
> are: AbstractWindow#55
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
