[
https://issues.apache.org/jira/browse/WICKET-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307272#comment-16307272
]
Christoph Läubrich edited comment on WICKET-6509 at 12/31/17 5:50 PM:
----------------------------------------------------------------------
[~mgrigorov] first of all, thanks for taking care about this.
I think nino mixed up <DynamicImport-Package> with <ImportPackage>
because DynamicImport-Package is an OSGi-Header that is evaluated at runtime
(and thus too late for fixing the initial problem) and does not allow excludes,
where the <ImportPackage> is evaluated by BND at compile time and that is what
we need here.
So if you can adjust this (the rest looks fine) everything should be
okay:{code}<Import-Package>org.apache.wicket*
org.junit*;resolution:=optional
junit.framework*;resolution:=optional</Import-Package>
<DynamicImport-Package>*</DynamicImport-Package>{code}
If you need more clarifications or are interested in more details about this
topic let me know. Is there some kind of snapshot repro? I would then verify
that every think works as intended as soon as possible.
BTW: I always wondered if it would make sense to include the pax-wicket stuff
directly into wicket as a seperate module (wicket-osgi) instead of having a
seperate project independently from wicket itself. What do you think?
was (Author: laeubi):
[~mgrigorov] first of all, thanks for taking care about this.
I think nino mixed up <DynamicImport-Package> with <ImportPackage>
because DynamicImport-Package is an OSGi-Header that is evaluated at runtime
(and thus too late for fixing the initial problem) and does not allow excludes,
where the <ImportPackage> is evaluated by BND at compile time and that is what
we need here.
So if you can adjust this (the rest looks fine) everything should be
okay:{code}<Import-Package>org.apache.wicket*
org.junit*;resolution:=optional
junit.framework*;resolution:=optional</Import-Package>
<DynamicImport-Package>!junit.framework,!org.junit,*</DynamicImport-Package>{code}
If you need more clarifications or are interested in more details about this
topic let me know. Is there some kind of snapshot repro? I would then verify
that every think works as intended as soon as possible.
BTW: I always wondered if it would make sense to include the pax-wicket stuff
directly into wicket as a seperate module (wicket-osgi) instead of having a
seperate project independently from wicket itself. What do you think?
> Import junit packages as optional
> ---------------------------------
>
> Key: WICKET-6509
> URL: https://issues.apache.org/jira/browse/WICKET-6509
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 8.0.0-M8
> Reporter: Christoph Läubrich
> Assignee: Martin Grigorov
> Fix For: 8.0.0
>
>
> Currently the wicket-core and the wicket-util bundle import junit packages, I
> think they are not really required to run wicket but imported unintentionally.
> They could be excluded by adding !org.junit* to the maninifest header config
> section
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
