[ https://issues.apache.org/jira/browse/WICKET-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351698#comment-16351698 ]
ASF GitHub Bot commented on WICKET-6526: ---------------------------------------- GitHub user duesenklipper opened a pull request: https://github.com/apache/wicket/pull/264 WICKET-6526 check HTTP method for all form submissions this moves the HTTP method check from onFormSubmitted to onFormSubmitted(submitter) so that every form submission performs this check, instead of only non-ajax requests. also adds tests that verify this. You can merge this pull request into a Git repository by running: $ git pull https://github.com/duesenklipper/wicket wicket8/WICKET-6526-ajaxbutton-methodmismatch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/264.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #264 ---- commit a03ee37d17b2e07f3d74268a4d874ac92cf69925 Author: Carl-Eric Menzel <carl-eric.menzel@...> Date: 2018-02-03T23:10:23Z WICKET-6526 check HTTP method for all form submissions this moves the HTTP method check from onFormSubmitted to onFormSubmitted(submitter) so that every form submission performs this check, instead of only non-ajax requests. also adds tests that verify this. ---- > Ajax Buttons do not check for the HTTP method and thus don't respect > Form#onMethodMismatch > ------------------------------------------------------------------------------------------ > > Key: WICKET-6526 > URL: https://issues.apache.org/jira/browse/WICKET-6526 > Project: Wicket > Issue Type: Bug > Affects Versions: 6.28.0, 7.9.0, 8.0.0-M8 > Reporter: Carl-Eric Menzel > Assignee: Carl-Eric Menzel > Priority: Major > > Pretty much what it says in the summary: The HTTP method check is only done > in onFormSubmitted(), not in onFormSubmitted(submitter), which is what > AjaxButton and friends call directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)