[
https://issues.apache.org/jira/browse/WICKET-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421727#comment-16421727
]
ASF GitHub Bot commented on WICKET-6321:
----------------------------------------
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/273#discussion_r178463264
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java ---
@@ -200,7 +207,13 @@ public static CssReferenceHeaderItem
forReference(ResourceReference reference,
public static CssReferenceHeaderItem forReference(ResourceReference
reference,
PageParameters pageParameters, String media, String condition,
String rel)
{
- return new CssReferenceHeaderItem(reference, pageParameters,
media, condition, rel);
+ final CssReferenceHeaderItem cssReferenceHeaderItem = new
CssReferenceHeaderItem(reference, pageParameters, media, condition, rel);
+ if(reference instanceof IntegrityAttributed) {
--- End diff --
whitespaces: space after `if`, line break before `{`
and the whole PR
> Support Integrity and Crossorigin attributes for
> JavaScriptUrlReferenceHeaderItem
> ----------------------------------------------------------------------------------
>
> Key: WICKET-6321
> URL: https://issues.apache.org/jira/browse/WICKET-6321
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 8.0.0-M3
> Reporter: Mikhail Fursov
> Priority: Major
> Fix For: 8.0.0
>
> Attachments: wicket-6321-20180306.diff, wicket-6321.diff
>
>
> Example of secure script reference:
> <script
> src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.6/js/bootstrap.min.js";
> integrity="sha256-+kIbbrvS+0dNOjhmQJzmwe/RILR/8lb/+4+PUNVW09k="
> crossorigin="anonymous"></script>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
