[
https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426201#comment-16426201
]
Sven Meier commented on WICKET-6546:
------------------------------------
I'd prefer if we applied the change to Wicket 7 and 8 only.
There are really old Wicket 6 projects out there that might not work with this
change. This issue isn't so important that we should take any risk.
> CssContentHeaderItem comments CSS code with HTML comments
> ---------------------------------------------------------
>
> Key: WICKET-6546
> URL: https://issues.apache.org/jira/browse/WICKET-6546
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.24.0, 6.29.0
> Reporter: Robert Niestroj
> Assignee: Maxim Solodovnik
> Priority: Minor
> Attachments: wicket6546 (2).zip
>
>
> CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering
> invalid markup.
> Example code:
>
> {code:java}
> @Override
> public void renderHead(Component component, IHeaderResponse response) {
> super.renderHead(component, response);
> response.render(CssContentHeaderItem.forCSS(".select2-container--open
> {z-index: 100000;}", "select2-mod", ""));
> }
> {code}
> Renders:
>
> {code:java}
> <style type="text/css" id="select2-mod">
> <!-- .select2-container--open {z-index: 100000;}-->
> </style>{code}
> The HTML comments in the CSS make the response invalid and in the browser you
> get a XML Parsing Error - Not Well Formed.
>
> It should not render this invalid html comments in CSS.
> Looking at the source code i think the error is in the CssUtils class:
> https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
