[
https://issues.apache.org/jira/browse/WICKET-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445445#comment-16445445
]
ASF GitHub Bot commented on WICKET-6550:
----------------------------------------
Github user Jezza commented on a diff in the pull request:
https://github.com/apache/wicket/pull/276#discussion_r182968690
--- Diff: wicket-core/src/main/java/org/apache/wicket/Session.java ---
@@ -422,6 +422,7 @@ public Locale getLocale()
* @return The metadata
* @see MetaDataKey
*/
+ @Override
public synchronized final <M extends Serializable> M getMetaData(final
MetaDataKey<M> key)
--- End diff --
Ah, got it.
Yeah, stupid mistake.
I think initially I mistook the error for the sync modifier, but it was the
`T object` parameter.
Reverted that weird change.
> Unify all metadata capable objects.
> -----------------------------------
>
> Key: WICKET-6550
> URL: https://issues.apache.org/jira/browse/WICKET-6550
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Jezza
> Priority: Minor
> Attachments: Test.java, mock.txt
>
>
> Application, Session, RequestCycle, and Component all have #setMetadata and
> #getMetadata methods, but lack some super object to unify them all.
> These leads to annoying complex code if you wish to implement some extra
> functionality.
> I propose that we unify them all with one interface.
> I've attached a mock idea that would solve it, and I'll work on a prototype
> and submit a PR so anyone can take a look.
> I'll add a comment here with the PR number.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
