Repository: wicket Updated Branches: refs/heads/master a148ac132 -> 69f8f058d
Adds missing @Override annotations Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/2e880482 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/2e880482 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/2e880482 Branch: refs/heads/master Commit: 2e880482c47846ea79125279f4bea656cfd0b50f Parents: 3200587 Author: Ryo Tsunoda <[email protected]> Authored: Sun Jul 15 22:06:58 2018 +0900 Committer: Ryo Tsunoda <[email protected]> Committed: Sun Jul 15 22:06:58 2018 +0900 ---------------------------------------------------------------------- .../bean/validation/BeanValidationConfiguration.java | 1 + .../bean/validation/SessionLocaleInterpolator.java | 2 ++ .../wicket/markup/html/PackageResourceGuard.java | 1 + .../wicket/markup/html/list/PageableListView.java | 1 + .../wicket/markup/repeater/AbstractPageableView.java | 1 + .../org/apache/wicket/model/StringResourceModel.java | 1 + .../org/apache/wicket/page/PageStoreManager.java | 1 + .../wicket/protocol/http/AbstractRequestLogger.java | 1 + .../protocol/http/BufferedHttpServletResponse.java | 4 ++++ .../protocol/http/mock/MockHttpServletRequest.java | 1 + .../protocol/http/mock/MockHttpServletResponse.java | 4 ++++ .../org/apache/wicket/settings/ResourceSettings.java | 3 +++ .../apache/wicket/util/reference/ClassReference.java | 1 + .../apache/wicket/validation/CompoundValidator.java | 1 + .../wicket/devutils/inspector/EnhancedPageView.java | 1 + .../data/sort/AjaxFallbackOrderByBorder.java | 1 + .../html/form/datetime/LocalDateTimeField.java | 1 + .../markup/html/form/datetime/TimeField.java | 1 + .../html/form/datetime/ZonedDateTimeField.java | 1 + .../extensions/markup/html/form/palette/Palette.java | 2 ++ .../markup/html/repeater/data/table/DataTable.java | 1 + .../repeater/data/table/export/CSVDataExporter.java | 1 + .../wicket/protocol/ws/AbstractUpgradeFilter.java | 15 ++++++++------- .../registry/SimpleWebSocketConnectionRegistry.java | 1 + .../request/http/handler/RedirectRequestHandler.java | 1 + .../org/apache/wicket/util/io/BOMInputStream.java | 3 ++- 26 files changed, 44 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/BeanValidationConfiguration.java ---------------------------------------------------------------------- diff --git a/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/BeanValidationConfiguration.java b/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/BeanValidationConfiguration.java index 683ff80..a36a248 100644 --- a/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/BeanValidationConfiguration.java +++ b/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/BeanValidationConfiguration.java @@ -62,6 +62,7 @@ public class BeanValidationConfiguration implements BeanValidationContext } + @Override @SuppressWarnings("unchecked") public <T extends Annotation> ITagModifier<T> getTagModifier(Class<T> annotationType) { http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SessionLocaleInterpolator.java ---------------------------------------------------------------------- diff --git a/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SessionLocaleInterpolator.java b/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SessionLocaleInterpolator.java index f8927e2..02828a3 100644 --- a/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SessionLocaleInterpolator.java +++ b/wicket-bean-validation/src/main/java/org/apache/wicket/bean/validation/SessionLocaleInterpolator.java @@ -28,6 +28,7 @@ public class SessionLocaleInterpolator implements MessageInterpolator this.delegate = delegate; } + @Override public String interpolate(final String messageTemplate, final MessageInterpolator.Context context) { @@ -42,6 +43,7 @@ public class SessionLocaleInterpolator implements MessageInterpolator } } + @Override public String interpolate(final String message, final MessageInterpolator.Context context, final Locale locale) { http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/markup/html/PackageResourceGuard.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/PackageResourceGuard.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/PackageResourceGuard.java index c06590b..1381b6b 100644 --- a/wicket-core/src/main/java/org/apache/wicket/markup/html/PackageResourceGuard.java +++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/PackageResourceGuard.java @@ -64,6 +64,7 @@ public class PackageResourceGuard implements IPackageResourceGuard /** * @see org.apache.wicket.markup.html.IPackageResourceGuard#accept(java.lang.String) */ + @Override public boolean accept(String path) { int ixExtension = path.lastIndexOf('.'); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/markup/html/list/PageableListView.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/list/PageableListView.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/list/PageableListView.java index f20cf8d..24e9a92 100644 --- a/wicket-core/src/main/java/org/apache/wicket/markup/html/list/PageableListView.java +++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/list/PageableListView.java @@ -121,6 +121,7 @@ public abstract class PageableListView<T> extends ListView<T> implements IPageab * @param itemsPerPage * the maximum number of rows on each page. */ + @Override public final void setItemsPerPage(long itemsPerPage) { if (itemsPerPage < 0) http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/markup/repeater/AbstractPageableView.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/repeater/AbstractPageableView.java b/wicket-core/src/main/java/org/apache/wicket/markup/repeater/AbstractPageableView.java index 8b98077..437d96d 100644 --- a/wicket-core/src/main/java/org/apache/wicket/markup/repeater/AbstractPageableView.java +++ b/wicket-core/src/main/java/org/apache/wicket/markup/repeater/AbstractPageableView.java @@ -172,6 +172,7 @@ public abstract class AbstractPageableView<T> extends RefreshingView<T> implemen * * @param items */ + @Override public final void setItemsPerPage(long items) { if (items < 1) http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/model/StringResourceModel.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/model/StringResourceModel.java b/wicket-core/src/main/java/org/apache/wicket/model/StringResourceModel.java index f95ee0b..2364fa2 100644 --- a/wicket-core/src/main/java/org/apache/wicket/model/StringResourceModel.java +++ b/wicket-core/src/main/java/org/apache/wicket/model/StringResourceModel.java @@ -590,6 +590,7 @@ public class StringResourceModel extends LoadableDetachableModel<String> if (model != null) { return new PropertyVariableInterpolator(resourceKey, model.getObject()) { + @Override protected String getValue(String variableName) { String result = super.getValue(variableName); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/page/PageStoreManager.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/page/PageStoreManager.java b/wicket-core/src/main/java/org/apache/wicket/page/PageStoreManager.java index 88c1645..e1b543a 100644 --- a/wicket-core/src/main/java/org/apache/wicket/page/PageStoreManager.java +++ b/wicket-core/src/main/java/org/apache/wicket/page/PageStoreManager.java @@ -56,6 +56,7 @@ public class PageStoreManager extends AbstractPageManager */ private static final ThreadLocal<Boolean> STORING_TOUCHED_PAGES = new ThreadLocal<Boolean>() { + @Override protected Boolean initialValue() { return Boolean.FALSE; http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java index ea5fcaa..43150c6 100644 --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java @@ -295,6 +295,7 @@ public abstract class AbstractRequestLogger implements IRequestLogger requestCycle.setMetaData(SESSION_DATA, sessionData); } + @Override public RequestData getCurrentRequest() { RequestCycle requestCycle = RequestCycle.get(); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/protocol/http/BufferedHttpServletResponse.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/BufferedHttpServletResponse.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/BufferedHttpServletResponse.java index 234a291..f8c8b9b 100644 --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/BufferedHttpServletResponse.java +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/BufferedHttpServletResponse.java @@ -603,6 +603,7 @@ class BufferedHttpServletResponse implements HttpServletResponse * @see javax.servlet.http.HttpServletResponse#setStatus(int) * @return status */ + @Override public int getStatus() { return status; @@ -613,6 +614,7 @@ class BufferedHttpServletResponse implements HttpServletResponse * @param name * @return the first header with name */ + @Override public String getHeader(String name) { Object value = headers.getFirstValue(name); @@ -628,6 +630,7 @@ class BufferedHttpServletResponse implements HttpServletResponse * @param name * @return all headers with name */ + @Override public Collection<String> getHeaders(String name) { List<Object> values = headers.get(name); @@ -647,6 +650,7 @@ class BufferedHttpServletResponse implements HttpServletResponse * @see javax.servlet.http.HttpServletRequest#getHeaderNames() * @return all header names */ + @Override public Collection<String> getHeaderNames() { return Collections.unmodifiableCollection(headers.keySet()); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java index a9396ba..5ca94b2 100755 --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java @@ -1773,6 +1773,7 @@ public class MockHttpServletRequest implements HttpServletRequest /** * @return ServletContext */ + @Override public ServletContext getServletContext() { return context; http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletResponse.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletResponse.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletResponse.java index 44cbf2b..6288863 100755 --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletResponse.java +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletResponse.java @@ -337,6 +337,7 @@ public class MockHttpServletResponse implements HttpServletResponse, IMetaDataBu * The header name * @return The value, or null */ + @Override @SuppressWarnings("unchecked") public String getHeader(final String name) { @@ -356,6 +357,7 @@ public class MockHttpServletResponse implements HttpServletResponse, IMetaDataBu * * @return The header names */ + @Override public Set<String> getHeaderNames() { return headers.keySet(); @@ -403,6 +405,7 @@ public class MockHttpServletResponse implements HttpServletResponse, IMetaDataBu * * @return The status code */ + @Override public int getStatus() { return status; @@ -876,6 +879,7 @@ public class MockHttpServletResponse implements HttpServletResponse, IMetaDataBu * @param name * @return headers with given name */ + @Override public Collection<String> getHeaders(String name) { return Collections.singletonList(headers.get(name).toString()); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/settings/ResourceSettings.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/settings/ResourceSettings.java b/wicket-core/src/main/java/org/apache/wicket/settings/ResourceSettings.java index 5d45308..6e59f82 100644 --- a/wicket-core/src/main/java/org/apache/wicket/settings/ResourceSettings.java +++ b/wicket-core/src/main/java/org/apache/wicket/settings/ResourceSettings.java @@ -240,6 +240,7 @@ public class ResourceSettings implements IPropertiesFactoryContext return this; } + @Override public Localizer getLocalizer() { if (localizer == null) @@ -304,6 +305,7 @@ public class ResourceSettings implements IPropertiesFactoryContext return resourcePollFrequency; } + @Override public IResourceStreamLocator getResourceStreamLocator() { if (resourceStreamLocator == null) @@ -316,6 +318,7 @@ public class ResourceSettings implements IPropertiesFactoryContext return resourceStreamLocator; } + @Override public IModificationWatcher getResourceWatcher(boolean start) { if (resourceWatcher == null && start) http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/util/reference/ClassReference.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/util/reference/ClassReference.java b/wicket-core/src/main/java/org/apache/wicket/util/reference/ClassReference.java index 8aa2fc2..441b406 100644 --- a/wicket-core/src/main/java/org/apache/wicket/util/reference/ClassReference.java +++ b/wicket-core/src/main/java/org/apache/wicket/util/reference/ClassReference.java @@ -52,6 +52,7 @@ public class ClassReference<T> implements Serializable, Supplier<Class<T>> /** * @return the {@link Class} stored in this reference */ + @Override public Class<T> get() { Class<T> clazz = cache != null ? cache.get() : null; http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-core/src/main/java/org/apache/wicket/validation/CompoundValidator.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/validation/CompoundValidator.java b/wicket-core/src/main/java/org/apache/wicket/validation/CompoundValidator.java index 77b2c60..7dcada8 100644 --- a/wicket-core/src/main/java/org/apache/wicket/validation/CompoundValidator.java +++ b/wicket-core/src/main/java/org/apache/wicket/validation/CompoundValidator.java @@ -148,6 +148,7 @@ public class CompoundValidator<T> extends Behavior implements IValidator<T> } } + @Override public boolean getStatelessHint(Component component) { for (IValidator<T> validator : validators) { http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/EnhancedPageView.java ---------------------------------------------------------------------- diff --git a/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/EnhancedPageView.java b/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/EnhancedPageView.java index 50856ed..2710327 100644 --- a/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/EnhancedPageView.java +++ b/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/EnhancedPageView.java @@ -305,6 +305,7 @@ public final class EnhancedPageView extends GenericPanel<Page> { private static final long serialVersionUID = 1L; + @Override public void onClick(Optional<AjaxRequestTarget> targetOptional) { expandState.expandAll(); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/sort/AjaxFallbackOrderByBorder.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/sort/AjaxFallbackOrderByBorder.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/sort/AjaxFallbackOrderByBorder.java index e91c949..0dafa66 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/sort/AjaxFallbackOrderByBorder.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/sort/AjaxFallbackOrderByBorder.java @@ -87,6 +87,7 @@ public abstract class AjaxFallbackOrderByBorder<S> extends OrderByBorder<S> /** * This method is a hook for subclasses to perform an action after sort has changed */ + @Override protected void onSortChanged() { // noop http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/LocalDateTimeField.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/LocalDateTimeField.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/LocalDateTimeField.java index 2283904..c803c31 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/LocalDateTimeField.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/LocalDateTimeField.java @@ -67,6 +67,7 @@ public class LocalDateTimeField extends AbstractDateTimeField<LocalDateTime> return temporal.toLocalDate(); } + @Override protected LocalTime getLocalTime(LocalDateTime temporal) { return temporal.toLocalTime(); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/TimeField.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/TimeField.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/TimeField.java index 8f56031..7fd78ad 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/TimeField.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/TimeField.java @@ -67,6 +67,7 @@ public class TimeField extends FormComponentPanel<LocalTime> { private static final long serialVersionUID = 1L; + @Override protected NumberFormat newNumberFormat(Locale locale) { return new DecimalFormat("00"); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/ZonedDateTimeField.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/ZonedDateTimeField.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/ZonedDateTimeField.java index c1b8403..3107694 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/ZonedDateTimeField.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime/ZonedDateTimeField.java @@ -62,6 +62,7 @@ public class ZonedDateTimeField extends AbstractDateTimeField<ZonedDateTime> * * @see ZoneId#systemDefault() */ + @Override protected ZonedDateTime createTemporal(LocalDate date, LocalTime time) { return ZonedDateTime.of(date, time, ZoneId.systemDefault()); } http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java index 93432f9..b26f42c 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java @@ -416,6 +416,7 @@ public class Palette<T> extends FormComponentPanel<Collection<T>> { private static final long serialVersionUID = 1L; + @Override protected void onComponentTag(ComponentTag tag) { super.onComponentTag(tag); @@ -436,6 +437,7 @@ public class Palette<T> extends FormComponentPanel<Collection<T>> { private static final long serialVersionUID = 1L; + @Override protected void onComponentTag(ComponentTag tag) { super.onComponentTag(tag); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java index 261e04e..003db19 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTable.java @@ -349,6 +349,7 @@ public class DataTable<T, S> extends Panel implements IPageableItems * number of items to display per page * */ + @Override public void setItemsPerPage(final long items) { datagrid.setItemsPerPage(items); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/export/CSVDataExporter.java ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/export/CSVDataExporter.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/export/CSVDataExporter.java index 1c50c22..d41a418 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/export/CSVDataExporter.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/export/CSVDataExporter.java @@ -293,6 +293,7 @@ public class CSVDataExporter extends AbstractDataExporter first = true; } + @Override public void close() throws IOException { writer.close(); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/AbstractUpgradeFilter.java ---------------------------------------------------------------------- diff --git a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/AbstractUpgradeFilter.java b/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/AbstractUpgradeFilter.java index 475a5af..1ab39c9 100644 --- a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/AbstractUpgradeFilter.java +++ b/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/AbstractUpgradeFilter.java @@ -16,13 +16,6 @@ */ package org.apache.wicket.protocol.ws; -import org.apache.wicket.ThreadContext; -import org.apache.wicket.protocol.http.WebApplication; -import org.apache.wicket.protocol.http.WicketFilter; -import org.apache.wicket.request.cycle.RequestCycle; -import org.apache.wicket.request.http.WebResponse; -import org.apache.wicket.util.string.Strings; - import java.io.IOException; import java.util.ArrayList; import java.util.Enumeration; @@ -33,6 +26,13 @@ import javax.servlet.ServletException; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +import org.apache.wicket.ThreadContext; +import org.apache.wicket.protocol.http.WebApplication; +import org.apache.wicket.protocol.http.WicketFilter; +import org.apache.wicket.request.cycle.RequestCycle; +import org.apache.wicket.request.http.WebResponse; +import org.apache.wicket.util.string.Strings; + /** * An extension of WicketFilter that is used to check whether * the processed HttpServletRequest needs to upgrade its protocol @@ -52,6 +52,7 @@ public class AbstractUpgradeFilter extends WicketFilter super(application); } + @Override protected boolean processRequestCycle(final RequestCycle requestCycle, final WebResponse webResponse, final HttpServletRequest httpServletRequest, final HttpServletResponse httpServletResponse, final FilterChain chain) http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/SimpleWebSocketConnectionRegistry.java ---------------------------------------------------------------------- diff --git a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/SimpleWebSocketConnectionRegistry.java b/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/SimpleWebSocketConnectionRegistry.java index 39c2b6b..d21676c 100644 --- a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/SimpleWebSocketConnectionRegistry.java +++ b/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/SimpleWebSocketConnectionRegistry.java @@ -86,6 +86,7 @@ public class SimpleWebSocketConnectionRegistry implements IWebSocketConnectionRe * The application * @return a collection of currently active websockets */ + @Override public Collection<IWebSocketConnection> getConnections(Application application) { Args.notNull(application, "application"); http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java ---------------------------------------------------------------------- diff --git a/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java b/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java index ed4a331..f5dd643 100644 --- a/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java +++ b/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java @@ -85,6 +85,7 @@ public class RedirectRequestHandler implements IRequestHandler return status; } + @Override public void respond(final IRequestCycle requestCycle) { final String location; http://git-wip-us.apache.org/repos/asf/wicket/blob/2e880482/wicket-util/src/main/java/org/apache/wicket/util/io/BOMInputStream.java ---------------------------------------------------------------------- diff --git a/wicket-util/src/main/java/org/apache/wicket/util/io/BOMInputStream.java b/wicket-util/src/main/java/org/apache/wicket/util/io/BOMInputStream.java index 075dc89..6762721 100644 --- a/wicket-util/src/main/java/org/apache/wicket/util/io/BOMInputStream.java +++ b/wicket-util/src/main/java/org/apache/wicket/util/io/BOMInputStream.java @@ -135,7 +135,8 @@ public class BOMInputStream extends ProxyInputStream */ private static final Comparator<ByteOrderMark> ByteOrderMarkLengthComparator = new Comparator<ByteOrderMark>() { - public int compare(final ByteOrderMark bom1, final ByteOrderMark bom2) { + @Override + public int compare(final ByteOrderMark bom1, final ByteOrderMark bom2) { final int len1 = bom1.length(); final int len2 = bom2.length(); if (len1 > len2) {
