Andreas Müller created WICKET-6586:
--------------------------------------
Summary: Broken JavaScript due to fix charsetName in
JavaScriptPackageResource
Key: WICKET-6586
URL: https://issues.apache.org/jira/browse/WICKET-6586
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 7.10.0
Reporter: Andreas Müller
When running Wicket in DEPLOYMENT Mode, {{DefaultJavaScriptCompressor}} will be
set as JavaScript Compressor by default to strip Comments and Whitespaces from
JavaScript files.
In {{JavaScriptPackageResource }}the {{processResponse}} method the charsetName
fix to "UTF-8", when compressing JS files:
{code:java}
@Override
protected byte[] processResponse(final Attributes attributes, byte[] bytes)
{
final byte[] processedResponse = super.processResponse(attributes, bytes);
IJavaScriptCompressor compressor = getCompressor();
if (compressor != null && getCompress())
{
try
{
String charsetName = "UTF-8";
...{code}
If those JavaScript files are not in UTF-8, the Compressor can break those
files.
E.g. when using ISO-8859-15 and having umlauts in the file, the umlauts will be
replaced by the "REPLACEMENT CHARACTER "\uefbfbd".
There should be a way to specify the charsetName in
{{JavaScriptPackageResource}}.
E.g. by calling something like {{getResourceSettings().setJavaScriptCharset()}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
