[
https://issues.apache.org/jira/browse/WICKET-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628211#comment-16628211
]
ASF GitHub Bot commented on WICKET-5552:
----------------------------------------
GitHub user andruhon opened a pull request:
https://github.com/apache/wicket/pull/294
WICKET-5552 fix modal mousedown and make modal more extendable
Demo to reproduce the issue
https://github.com/andruhon/wicket-modal-mousedown-issue
Demo using 9.0.0-SNAPSHOT from maven local to demonstrate the fix:
https://github.com/andruhon/wicket-modal-mousedown-issue/tree/fix-WICKET-5552
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andruhon/wicket
WICKET-5552-fix-modal-mousedown-and-make-it-more-extendable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/294.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #294
----
commit 3adf1b5144b5948c45100129c6279fa183d85420
Author: Andrew Kondratev <andruhon@...>
Date: 2018-09-26T02:58:11Z
WICKET-5552 fix modal mousedown and make it more extendable
----
> Events to close pop-up on Modal Window are not propagated
> ---------------------------------------------------------
>
> Key: WICKET-5552
> URL: https://issues.apache.org/jira/browse/WICKET-5552
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.14.0
> Environment: Windows/Eclipse/JRE7
> Reporter: Neil Bennett
> Priority: Major
> Labels: javascript, modalwindow
> Attachments: quickstart.zip
>
>
> When using a field on a modal window that shows a pop-up window, like a time
> picker, when clicking outside of the pop-up window but over the modal window,
> mousedown/click events are not propagated. Clicks outside of the modal window
> are propagated.
> This is due to Wicket.Event.stop(event) being called on mousedown on the
> w_content_1 component. Removal of this leads to the Drag javascript being
> executed which itself calls Wicket.Event.stop(event), disabling this then
> propagates the event which leads to the pop-up window being closed but causes
> any field on the modalwindow to get focus.
> I have a quickstart that demonstrates the modalwindow behavior vs that on a
> page. You will see that launching the modal window and clicking on the time
> component opens the pop-up window. However, you can only get this to close
> when clicking outside of the modal window. The same component has been put on
> the main page as a comparison which does close when clicking outside of the
> pop-up window.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
