[ 
https://issues.apache.org/jira/browse/WICKET-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655088#comment-16655088
 ] 

ASF subversion and git services commented on WICKET-6599:
---------------------------------------------------------

Commit c01c22bd1d61ec670eae926dfafdf261f63e0521 in wicket's branch 
refs/heads/wicket-8.x from [~emond]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=c01c22b ]

WICKET-6599: unwrap ResponseIOException before leaving WicketFilter


> ResponseIOException should never escape from WicketFilter
> ---------------------------------------------------------
>
>                 Key: WICKET-6599
>                 URL: https://issues.apache.org/jira/browse/WICKET-6599
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 8.1.0
>            Reporter: Emond Papegaaij
>            Assignee: Emond Papegaaij
>            Priority: Minor
>
> We are observing the stacktrace below in the logs on our systems. The problem 
> is that Wicket wraps the IOException in a ReponseIOException and lets this 
> exception escape from the filter. Undertow logs IOExceptions at debug, but 
> the ReponseIOException is considered a real error and logged at error.
> {code}
> 2018-10-02 08:04:51,307 ERROR [io.undertow.request] (default task-540) 
> UT005023: Exception handling request to 
> /console/wicket/resource/assets.AssetsResourceReferenceMarker/fonts/flaticons-stroke.woff:
>  javax.servlet.ServletException: 
> org.apache.wicket.protocol.http.servlet.ResponseIOException: 
> java.io.IOException: Broken pipe
>         at 
> org.apache.shiro.web.servlet.AdviceFilter.cleanup(AdviceFilter.java:196)
>         at 
> org.apache.shiro.web.servlet.AdviceFilter.doFilterInternal(AdviceFilter.java:148)
>         at 
> org.apache.shiro.web.servlet.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:125)
>         at 
> org.apache.shiro.web.servlet.ProxiedFilterChain.doFilter(ProxiedFilterChain.java:66)
>         at 
> org.apache.shiro.web.servlet.AbstractShiroFilter.executeChain(AbstractShiroFilter.java:449)
>         at 
> org.apache.shiro.web.servlet.AbstractShiroFilter$1.call(AbstractShiroFilter.java:365)
>         at 
> org.apache.shiro.subject.support.SubjectCallable.doCall(SubjectCallable.java:90)
>         at 
> org.apache.shiro.subject.support.SubjectCallable.call(SubjectCallable.java:83)
>         at 
> org.apache.shiro.subject.support.DelegatingSubject.execute(DelegatingSubject.java:387)
>         at 
> org.apache.shiro.web.servlet.AbstractShiroFilter.doFilterInternal(AbstractShiroFilter.java:362)
>         at 
> org.apache.shiro.web.servlet.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:125)
>         at 
> io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
>         at 
> io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
>         at 
> org.apache.deltaspike.servlet.impl.produce.RequestResponseHolderFilter.doFilter(RequestResponseHolderFilter.java:63)
>         at 
> io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
>         at 
> io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
>         at 
> nl.topicus.cobra.filter.ClickjackFilter.doFilter(ClickjackFilter.java:29)
>         at 
> io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
>         at 
> io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
>         at 
> io.undertow.servlet.handlers.FilterHandler.handleRequest(FilterHandler.java:84)
>         at 
> io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62)
>         at 
> io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68)
>         at 
> io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36)
>         at 
> org.wildfly.extension.undertow.security.SecurityContextAssociationHandler.handleRequest(SecurityContextAssociationHandler.java:78)
>         at 
> io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
>         at 
> io.undertow.servlet.handlers.security.SSLInformationAssociationHandler.handleRequest(SSLInformationAssociationHandler.java:132)
>         at 
> io.undertow.servlet.handlers.security.ServletAuthenticationCallHandler.handleRequest(ServletAuthenticationCallHandler.java:57)
>         at 
> io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
>         at 
> io.undertow.security.handlers.AbstractConfidentialityHandler.handleRequest(AbstractConfidentialityHandler.java:46)
>         at 
> io.undertow.servlet.handlers.security.ServletConfidentialityConstraintHandler.handleRequest(ServletConfidentialityConstraintHandler.java:64)
>         at 
> io.undertow.security.handlers.AuthenticationMechanismsHandler.handleRequest(AuthenticationMechanismsHandler.java:60)
>         at 
> io.undertow.servlet.handlers.security.CachedAuthenticatedSessionHandler.handleRequest(CachedAuthenticatedSessionHandler.java:77)
>         at 
> io.undertow.security.handlers.NotificationReceiverHandler.handleRequest(NotificationReceiverHandler.java:50)
>         at 
> io.undertow.security.handlers.AbstractSecurityContextAssociationHandler.handleRequest(AbstractSecurityContextAssociationHandler.java:43)
>         at 
> io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
>         at 
> org.wildfly.extension.undertow.security.jacc.JACCContextIdHandler.handleRequest(JACCContextIdHandler.java:61)
>         at 
> io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
>         at 
> org.wildfly.extension.undertow.deployment.GlobalRequestControllerHandler.handleRequest(GlobalRequestControllerHandler.java:68)
>         at 
> io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
>         at 
> io.undertow.servlet.handlers.ServletInitialHandler.handleFirstRequest(ServletInitialHandler.java:292)
>         at 
> io.undertow.servlet.handlers.ServletInitialHandler.access$100(ServletInitialHandler.java:81)
>         at 
> io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:138)
>         at 
> io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:135)
>         at 
> io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:48)
>         at 
> io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43)
>         at 
> org.wildfly.extension.undertow.security.SecurityContextThreadSetupAction.lambda$create$0(SecurityContextThreadSetupAction.java:105)
>         at 
> org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1514)
>         at 
> org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1514)
>         at 
> org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1514)
>         at 
> org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1514)
>         at 
> io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:272)
>         at 
> io.undertow.servlet.handlers.ServletInitialHandler.access$000(ServletInitialHandler.java:81)
>         at 
> io.undertow.servlet.handlers.ServletInitialHandler$1.handleRequest(ServletInitialHandler.java:104)
>         at 
> io.undertow.server.Connectors.executeRootHandler(Connectors.java:360)
>         at 
> io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:830)
>         at 
> org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
>         at 
> org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1985)
>         at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1487)
>         at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1378)
>         at java.lang.Thread.run(Thread.java:748)
> Caused by: org.apache.wicket.protocol.http.servlet.ResponseIOException: 
> java.io.IOException: Broken pipe
>         at 
> org.apache.wicket.protocol.http.servlet.ServletWebResponse.flush(ServletWebResponse.java:316)
>         at 
> org.apache.wicket.protocol.http.HeaderBufferingWebResponse.flush(HeaderBufferingWebResponse.java:99)
>         at 
> org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:264)
>         at 
> org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:204)
>         at 
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:286)
>         at 
> io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61)
>         at 
> io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131)
>         at 
> org.apache.shiro.web.servlet.ProxiedFilterChain.doFilter(ProxiedFilterChain.java:61)
>         at 
> org.apache.shiro.web.servlet.AdviceFilter.executeChain(AdviceFilter.java:108)
>         at 
> org.apache.shiro.web.servlet.AdviceFilter.doFilterInternal(AdviceFilter.java:137)
>         ... 58 more
> Caused by: java.io.IOException: Broken pipe
>         at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
>         at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47)
>         at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
>         at sun.nio.ch.IOUtil.write(IOUtil.java:51)
>         at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:471)
>         at org.xnio.nio.NioSocketConduit.write(NioSocketConduit.java:153)
>         at 
> org.xnio.conduits.AbstractStreamSinkConduit.write(AbstractStreamSinkConduit.java:51)
>         at 
> io.undertow.conduits.WriteTimeoutStreamSinkConduit.write(WriteTimeoutStreamSinkConduit.java:109)
>         at 
> io.undertow.server.protocol.http.HttpResponseConduit.write(HttpResponseConduit.java:609)
>         at 
> io.undertow.conduits.AbstractFixedLengthStreamSinkConduit.write(AbstractFixedLengthStreamSinkConduit.java:106)
>         at 
> org.xnio.conduits.ConduitStreamSinkChannel.write(ConduitStreamSinkChannel.java:150)
>         at 
> io.undertow.channels.DetachableStreamSinkChannel.write(DetachableStreamSinkChannel.java:240)
>         at 
> io.undertow.server.HttpServerExchange$WriteDispatchChannel.write(HttpServerExchange.java:2099)
>         at 
> io.undertow.servlet.spec.ServletOutputStreamImpl.writeBufferBlocking(ServletOutputStreamImpl.java:573)
>         at 
> io.undertow.servlet.spec.ServletOutputStreamImpl.flushInternal(ServletOutputStreamImpl.java:488)
>         at 
> io.undertow.servlet.spec.ServletOutputStreamImpl.flush(ServletOutputStreamImpl.java:475)
>         at 
> io.undertow.servlet.spec.HttpServletResponseImpl.flushBuffer(HttpServletResponseImpl.java:468)
>         at 
> org.apache.wicket.protocol.http.servlet.ServletWebResponse.flush(ServletWebResponse.java:311)
>         ... 67 more
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to