Repository: wicket Updated Branches: refs/heads/master a6d73f46b -> 8fc2eab45
WICKET-6606 data-wicket-placeholder xhtml conform Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/8fc2eab4 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/8fc2eab4 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/8fc2eab4 Branch: refs/heads/master Commit: 8fc2eab45577eceed732b252ee7190ab7db55387 Parents: a6d73f4 Author: Sven Meier <[email protected]> Authored: Tue Oct 30 22:13:47 2018 +0100 Committer: Sven Meier <[email protected]> Committed: Tue Oct 30 22:25:47 2018 +0100 ---------------------------------------------------------------------- wicket-core/src/main/java/org/apache/wicket/Component.java | 2 +- .../src/test/java/org/apache/wicket/PlaceholderTagIdTest.java | 2 +- .../org/apache/wicket/markup/html/internal/AjaxEnclosureTest.java | 2 +- .../markup/html/internal/InlineEnclosurePageExpectedResult_1.html | 2 +- .../InlineEnclosureWithWicketMessagePage_invisible_expected.html | 2 +- .../org/apache/wicket/markup/html/internal/TogglePageTest.java | 2 +- .../wicket/markup/html/panel/InlinePanelPageExpectedResult_8.html | 2 +- .../java/org/apache/wicket/queueing/ComponentQueueingTest.java | 2 +- wicket-core/src/test/js/all.html | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/8fc2eab4/wicket-core/src/main/java/org/apache/wicket/Component.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/Component.java b/wicket-core/src/main/java/org/apache/wicket/Component.java index 0f5fc7d..0a90016 100644 --- a/wicket-core/src/main/java/org/apache/wicket/Component.java +++ b/wicket-core/src/main/java/org/apache/wicket/Component.java @@ -2360,7 +2360,7 @@ public abstract class Component response.write(name); response.write(" id=\""); response.write(getAjaxRegionMarkupId()); - response.write("\" style=\"display:none\" data-wicket-placeholder></"); + response.write("\" style=\"display:none\" data-wicket-placeholder=\"\"></"); response.write(name); response.write(">"); } http://git-wip-us.apache.org/repos/asf/wicket/blob/8fc2eab4/wicket-core/src/test/java/org/apache/wicket/PlaceholderTagIdTest.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/java/org/apache/wicket/PlaceholderTagIdTest.java b/wicket-core/src/test/java/org/apache/wicket/PlaceholderTagIdTest.java index 3988176..5b98156 100644 --- a/wicket-core/src/test/java/org/apache/wicket/PlaceholderTagIdTest.java +++ b/wicket-core/src/test/java/org/apache/wicket/PlaceholderTagIdTest.java @@ -42,7 +42,7 @@ class PlaceholderTagIdTest extends WicketTestCase { tester.startPage(TestPage.class); - tester.assertContains("<form id=\"form1_region\" style=\"display:none\" data-wicket-placeholder>"); + tester.assertContains("<form id=\"form1_region\" style=\"display:none\" data-wicket-placeholder=\"\">"); } /** http://git-wip-us.apache.org/repos/asf/wicket/blob/8fc2eab4/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/AjaxEnclosureTest.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/AjaxEnclosureTest.java b/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/AjaxEnclosureTest.java index 162e343..8a16f20 100644 --- a/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/AjaxEnclosureTest.java +++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/AjaxEnclosureTest.java @@ -42,7 +42,7 @@ class AjaxEnclosureTest extends WicketTestCase { private final String inlineEnclosureIdPrefix = "wicket__InlineEnclosure_"; private final String inlineEnclosureHiddenPattern = "<div id=\"" + inlineEnclosureIdPrefix + - "\\w+\" style=\"display:none\" data-wicket-placeholder></div>"; + "\\w+\" style=\"display:none\" data-wicket-placeholder=\"\"></div>"; private final String inlineEnclosureVisiblePattern = "<div id=\"" + inlineEnclosureIdPrefix + "\\w+\">"; http://git-wip-us.apache.org/repos/asf/wicket/blob/8fc2eab4/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosurePageExpectedResult_1.html ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosurePageExpectedResult_1.html b/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosurePageExpectedResult_1.html index ff86786..4bc7e17 100644 --- a/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosurePageExpectedResult_1.html +++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosurePageExpectedResult_1.html @@ -11,7 +11,7 @@ </table> </div> -<span id="wicket__InlineEnclosure__15719789313" style="display:none" data-wicket-placeholder></span> +<span id="wicket__InlineEnclosure__15719789313" style="display:none" data-wicket-placeholder=""></span> <div id="wicket__InlineEnclosure__15719789304"> <table> http://git-wip-us.apache.org/repos/asf/wicket/blob/8fc2eab4/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosureWithWicketMessagePage_invisible_expected.html ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosureWithWicketMessagePage_invisible_expected.html b/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosureWithWicketMessagePage_invisible_expected.html index f48e405..330445e 100644 --- a/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosureWithWicketMessagePage_invisible_expected.html +++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/InlineEnclosureWithWicketMessagePage_invisible_expected.html @@ -21,6 +21,6 @@ <title>Wicket 4520</title> </head> <body> - <div id="wicket__message__attr___4340036351" style="display:none" data-wicket-placeholder></div> + <div id="wicket__message__attr___4340036351" style="display:none" data-wicket-placeholder=""></div> </body> </html> \ No newline at end of file http://git-wip-us.apache.org/repos/asf/wicket/blob/8fc2eab4/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/TogglePageTest.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/TogglePageTest.java b/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/TogglePageTest.java index eaf2a90..12a09c3 100644 --- a/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/TogglePageTest.java +++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/internal/TogglePageTest.java @@ -162,7 +162,7 @@ class TogglePageTest extends WicketTestCase String inlineEnclosureIdPrefix = "wicket__InlineEnclosure_"; String inlineEnclosureHiddenPattern = "<tr id=\"" + inlineEnclosureIdPrefix + - "\\w+\" style=\"display:none\" data-wicket-placeholder></tr>"; + "\\w+\" style=\"display:none\" data-wicket-placeholder=\"\"></tr>"; String inlineEnclosureVisiblePattern = "<tr bgcolor=\"red\" id=\"" + inlineEnclosureIdPrefix + "\\w+\">"; http://git-wip-us.apache.org/repos/asf/wicket/blob/8fc2eab4/wicket-core/src/test/java/org/apache/wicket/markup/html/panel/InlinePanelPageExpectedResult_8.html ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/panel/InlinePanelPageExpectedResult_8.html b/wicket-core/src/test/java/org/apache/wicket/markup/html/panel/InlinePanelPageExpectedResult_8.html index a4ad33d..e27cfa3 100644 --- a/wicket-core/src/test/java/org/apache/wicket/markup/html/panel/InlinePanelPageExpectedResult_8.html +++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/panel/InlinePanelPageExpectedResult_8.html @@ -24,7 +24,7 @@ Wicket.Event.publish(Wicket.Event.Topic.AJAX_HANDLERS_BOUND); <div wicket:id="first"> <span wicket:id="number">0</span><br/> - <div id="nextContainer2" style="display:none" data-wicket-placeholder></div> + <div id="nextContainer2" style="display:none" data-wicket-placeholder=""></div> </div> <a wicket:id="add" id="add1" href="javascript:;">Add</a> http://git-wip-us.apache.org/repos/asf/wicket/blob/8fc2eab4/wicket-core/src/test/java/org/apache/wicket/queueing/ComponentQueueingTest.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/java/org/apache/wicket/queueing/ComponentQueueingTest.java b/wicket-core/src/test/java/org/apache/wicket/queueing/ComponentQueueingTest.java index 8cfefb7..8235682 100644 --- a/wicket-core/src/test/java/org/apache/wicket/queueing/ComponentQueueingTest.java +++ b/wicket-core/src/test/java/org/apache/wicket/queueing/ComponentQueueingTest.java @@ -601,7 +601,7 @@ class ComponentQueueingTest extends WicketTestCase a.setVisible(false); tester.startPage(p); - assertEquals("<div id=\"wicket__InlineEnclosure_20793898271\" style=\"display:none\" data-wicket-placeholder></div>", tester.getLastResponseAsString()); + assertEquals("<div id=\"wicket__InlineEnclosure_20793898271\" style=\"display:none\" data-wicket-placeholder=\"\"></div>", tester.getLastResponseAsString()); } /** http://git-wip-us.apache.org/repos/asf/wicket/blob/8fc2eab4/wicket-core/src/test/js/all.html ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/js/all.html b/wicket-core/src/test/js/all.html index afe2b6b..58f0f85 100644 --- a/wicket-core/src/test/js/all.html +++ b/wicket-core/src/test/js/all.html @@ -89,7 +89,7 @@ <ajax-response><component id="titleId"><![CDATA[<title id="titleId">new title</title>]]></component></ajax-response> </textarea> - <div id="componentPlaceholderId" data-wicket-placeholder> + <div id="componentPlaceholderId" data-wicket-placeholder=""> </div> <!--
