[ 
https://issues.apache.org/jira/browse/WICKET-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876167#comment-16876167
 ] 

ASF subversion and git services commented on WICKET-6680:
---------------------------------------------------------

Commit d97831d7eb6653aefe3e87adffa2fee51a171f11 in wicket's branch 
refs/heads/wicket-8.x from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=d97831d ]

WICKET-6680 JUnit 4.x requires @Test methods to be public


> JavaScriptStripper chokes on template literals that contain two forward 
> slashes
> -------------------------------------------------------------------------------
>
>                 Key: WICKET-6680
>                 URL: https://issues.apache.org/jira/browse/WICKET-6680
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 8.5.0, 9.0.0-M2, 7.14.0
>            Reporter: Arthur Bogaart
>            Assignee: Martin Grigorov
>            Priority: Major
>             Fix For: 8.6.0, 7.15.0, 9.0.0-M3
>
>
> The DefaultJavaScriptCompressor uses the JavaScriptStripper to strip comments 
> and whitespace from javascript code when running in production mode, but it 
> has no support for / understanding of [template 
> literals|https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals].
>  As such, it chokes on the following snippet
> {code:java}
> const url = `${protocol}//${hostname}:${port}`;{code}
>  as it identifies the two forward slashes as the beginning of a single-line 
> comment, and removes the code after it, breaking the javascript.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to