[ 
https://issues.apache.org/jira/browse/WICKET-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899509#comment-16899509
 ] 

Emond Papegaaij commented on WICKET-6558:
-----------------------------------------

I think this issue still exists. If something in the users code accesses a page 
after {{commitRequest}}, it will be locked and the lock is never released. 
There is nothing wrong with the code in Wicket, it works as expected, but if 
the user makes an error, this can result in a situation that is very hard to 
debug. Stale locks will cause errors on the next request and you will not get 
any information on what went wrong. It would be nice if any attempt to acquire 
a page lock after {{commitRequest}} would simply be denied and would throw an 
exception.

> Prevent package locks after commitRequest
> -----------------------------------------
>
>                 Key: WICKET-6558
>                 URL: https://issues.apache.org/jira/browse/WICKET-6558
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 7.10.0
>            Reporter: Emond Papegaaij
>            Priority: Major
>
> We've had several incidents with page locks not being freed at the end of the 
> request. Often the cause of these locks were in our own code, but these 
> issues can be hard to debug. I think it should be better if 
> `PageAccessSynchronizer` would either refuse the aquire a lock after the 
> request has been committed or at least log an error.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to