[wicket] branch wicket-8.x updated: WICKET-6613 don't use null

[svenmeier]

This is an automated email from the ASF dual-hosted git repository.

svenmeier pushed a commit to branch wicket-8.x
in repository https://gitbox.apache.org/repos/asf/wicket.git


The following commit(s) were added to refs/heads/wicket-8.x by this push:
     new 2c064ae  WICKET-6613 don't use null
2c064ae is described below

commit 2c064ae4bf2cd8752e75dc7001d9645341ab93e3
Author: Sven Meier <svenme...@apache.org>
AuthorDate: Thu Aug 29 20:43:26 2019 +0200

    WICKET-6613 don't use null
    
    as it removes the key and the default height setting will overwrite
---
 .../apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
index a8a70ef..167b47a 100644
--- 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
+++ 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
@@ -1022,7 +1022,8 @@ public class ModalWindow extends Panel
                }
                else
                {
-                       settings.put("height", (Object)null);
+                       // WICKET-6613 null would remove the key, so use false 
instead 
+                       settings.put("height", false);
                }
 
                settings.put("resizable", isResizable());